[PATCH] net: phy: fixed: propagate fixed link values to struct

Subsystems: ethernet phy library, networking drivers, the rest

STALE4000d

2 messages, 2 authors, 2015-08-26 · open the first message on its own page

[PATCH] net: phy: fixed: propagate fixed link values to struct

From: Madalin Bucur <hidden>
Date: 2015-08-26 14:50:18

The fixed link values parsed from the device tree are stored in
the struct fixed_phy member status. The struct phy_device members
speed, duplex were not updated.

Signed-off-by: Madalin Bucur <redacted>
---
 drivers/net/phy/fixed_phy.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
index 479b93f..20731fc 100644
--- a/drivers/net/phy/fixed_phy.c
+++ b/drivers/net/phy/fixed_phy.c

@@ -292,6 +292,15 @@ struct phy_device *fixed_phy_register(unsigned int irq,
 		return ERR_PTR(-EINVAL);
 	}
 
+	/* propagate the fixed link values to struct phy_device */
+	if (status->link) {
+		phy->link = status->link;
+		phy->speed = status->speed;
+		phy->duplex = status->duplex;
+		phy->pause = status->pause;
+		phy->asym_pause = status->asym_pause;
+	}
+
 	of_node_get(np);
 	phy->dev.of_node = np;

-- 
1.7.11.7

Re: [PATCH] net: phy: fixed: propagate fixed link values to struct

From: Stas Sergeev <hidden>
Date: 2015-08-26 14:57:36

26.08.2015 17:48, Madalin Bucur пишет:

quoted hunk

The fixed link values parsed from the device tree are stored in
the struct fixed_phy member status. The struct phy_device members
speed, duplex were not updated.

Signed-off-by: Madalin Bucur <redacted>
---
 drivers/net/phy/fixed_phy.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
index 479b93f..20731fc 100644
--- a/drivers/net/phy/fixed_phy.c
+++ b/drivers/net/phy/fixed_phy.c

@@ -292,6 +292,15 @@ struct phy_device *fixed_phy_register(unsigned int irq,
 		return ERR_PTR(-EINVAL);
 	}
 
+	/* propagate the fixed link values to struct phy_device */
+	if (status->link) {
+		phy->link = status->link;

Oh, I wonder if you want to initialize phy->link regardless,
outside of the "if (status->link)" block.
Other than that,

Acked-by: Stas Sergeev <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help