# \[PATCH\] net: fs\_enet: explicitly remove I flag on TX partial frames - Subsystems: FREESCALE SOC FS\_ENET DRIVER, NETWORKING DRIVERS, THE REST - Maintainers: Pantelis Antoniou, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds - List: netdev - 2 messages, 2 authors - Page: https://ratatoskr.run/netdev/2015/08/4555608/t ## \[PATCH\] net: fs\_enet: explicitly remove I flag on TX partial frames - From: Christophe Leroy \ - Date: 2015-08-11 10:11:43 - Message: https://ratatoskr.run/netdev/2015/08/4555608.md ```text We are not interested in interrupts for partially transmitted frames, we have to clear BD_ENET_TX_INTR explicitly otherwise it may remain from a previously used descriptor. Signed-off-by: Christophe Leroy --- drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c index b9ad34e..84c18ee 100644 --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c @@ -585,7 +585,8 @@ static int fs_enet_start_xmit(struct sk_buff *skb, struct net_device *dev) frag = skb_shinfo(skb)->frags; while (nr_frags) { CBDC_SC(bdp, - BD_ENET_TX_STATS | BD_ENET_TX_LAST | BD_ENET_TX_TC); + BD_ENET_TX_STATS | BD_ENET_TX_INTR | BD_ENET_TX_LAST | + BD_ENET_TX_TC); CBDS_SC(bdp, BD_ENET_TX_READY); if ((CBDR_SC(bdp) & BD_ENET_TX_WRAP) == 0) -- 2.1.0 ``` ## Re: \[PATCH\] net: fs\_enet: explicitly remove I flag on TX partial frames - From: David Miller \ - Date: 2015-08-11 19:05:47 - Message: https://ratatoskr.run/netdev/2015/08/4555978.md ```text From: Christophe Leroy Date: Tue, 11 Aug 2015 12:11:00 +0200 (CEST) > We are not interested in interrupts for partially transmitted frames, > we have to clear BD_ENET_TX_INTR explicitly otherwise it may remain > from a previously used descriptor. > > Signed-off-by: Christophe Leroy Applied. ```