[PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

Subsystems: networking [general], the rest, tipc network layer

STALE3977d

4 messages, 3 authors, 2015-09-17 · open the first message on its own page

[PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

From: Andrzej Hajda <hidden>
Date: 2015-08-07 08:03:37

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda <redacted>
---
 net/tipc/server.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/tipc/server.c b/net/tipc/server.c
index 922e04a..c187cad 100644
--- a/net/tipc/server.c
+++ b/net/tipc/server.c

@@ -411,13 +411,12 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len)
 	if (!entry)
 		return NULL;
 
-	buf = kmalloc(len, GFP_ATOMIC);
+	buf = kmemdup(data, len, GFP_ATOMIC);
 	if (!buf) {
 		kfree(entry);
 		return NULL;
 	}
 
-	memcpy(buf, data, len);
 	entry->iov.iov_base = buf;
 	entry->iov.iov_len = len;

-- 
1.9.1

Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

From: Andrzej Hajda <hidden>
Date: 2015-09-16 10:07:34

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:

quoted hunk

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda <redacted>
---
 net/tipc/server.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/tipc/server.c b/net/tipc/server.c
index 922e04a..c187cad 100644
--- a/net/tipc/server.c
+++ b/net/tipc/server.c

@@ -411,13 +411,12 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len)
 	if (!entry)
 		return NULL;
 
-	buf = kmalloc(len, GFP_ATOMIC);
+	buf = kmemdup(data, len, GFP_ATOMIC);
 	if (!buf) {
 		kfree(entry);
 		return NULL;
 	}
 
-	memcpy(buf, data, len);
 	entry->iov.iov_base = buf;
 	entry->iov.iov_len = len;

Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

From: Ying Xue <hidden>
Date: 2015-09-17 01:19:20

On 08/07/2015 03:59 PM, Andrzej Hajda wrote:

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda <redacted>

Reviewed-by: Ying Xue <redacted>

quoted hunk

---
 net/tipc/server.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/tipc/server.c b/net/tipc/server.c
index 922e04a..c187cad 100644
--- a/net/tipc/server.c
+++ b/net/tipc/server.c

@@ -411,13 +411,12 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len)
 	if (!entry)
 		return NULL;
 
-	buf = kmalloc(len, GFP_ATOMIC);
+	buf = kmemdup(data, len, GFP_ATOMIC);
 	if (!buf) {
 		kfree(entry);
 		return NULL;
 	}
 
-	memcpy(buf, data, len);
 	entry->iov.iov_base = buf;
 	entry->iov.iov_len = len;

RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

From: Jon Maloy <hidden>
Date: 2015-09-17 09:58:21

Acked-by: Jon Maloy <redacted>

///jon

-----Original Message-----
From: Andrzej Hajda [mailto:a.hajda@samsung.com]
Sent: Wednesday, 16 September, 2015 06:07
To: Jon Maloy; Ying Xue
Cc: Bartlomiej Zolnierkiewicz; Marek Szyprowski; linux-
kernel@vger.kernel.org; David S. Miller; netdev@vger.kernel.org
Subject: Re: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its
implementation

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:

quoted

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda <redacted>
---
 net/tipc/server.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/tipc/server.c b/net/tipc/server.c index

922e04a..c187cad 100644

--- a/net/tipc/server.c
+++ b/net/tipc/server.c

@@ -411,13 +411,12 @@ static struct outqueue_entry

*tipc_alloc_entry(void *data, int len)

quoted

 	if (!entry)
 		return NULL;

-	buf = kmalloc(len, GFP_ATOMIC);
+	buf = kmemdup(data, len, GFP_ATOMIC);
 	if (!buf) {
 		kfree(entry);
 		return NULL;
 	}

-	memcpy(buf, data, len);
 	entry->iov.iov_base = buf;
 	entry->iov.iov_len = len;

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help