[PATCH, net-next]r8169:Disable interrupts.

Subsystems: 8169 10/100/1000 gigabit ethernet driver, networking drivers, the rest

2 messages, 2 authors, 2015-08-22 · open the first message on its own page

[PATCH, net-next]r8169:Disable interrupts.

From: Corcodel Marian <hidden>
Date: 2015-08-22 05:04:15 

Disable interrupts when close the interface.


Signed-off-by: Corcodel Marian <redacted>

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 6cd7226..ea461fe 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -7548,6 +7548,7 @@ static int rtl8169_close(struct net_device *dev)
 
 	/* Update counters before going down */
 	rtl8169_update_counters(dev);
+	rtl8169_irq_mask_and_ack(tp);
 
 	rtl_lock_work(tp);
 	clear_bit(RTL_FLAG_TASK_ENABLED, tp->wk.flags);
-- 
2.1.4

Re: [PATCH, net-next]r8169:Disable interrupts.

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2015-08-22 11:23:24 

Corcodel Marian [off-list ref] :
quoted hunk
Disable interrupts when close the interface.


Signed-off-by: Corcodel Marian <redacted>

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 6cd7226..ea461fe 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -7548,6 +7548,7 @@ static int rtl8169_close(struct net_device *dev)
 
 	/* Update counters before going down */
 	rtl8169_update_counters(dev);
+	rtl8169_irq_mask_and_ack(tp);
It's already called through
- rtl8169_close
  - rtl8169_down

-- 
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help