[PATCH net-next] bridge: fix netlink max attr size

Subsystems: ethernet bridge, networking [general], the rest

STALE4007d

2 messages, 2 authors, 2015-08-20 · open the first message on its own page

[PATCH net-next] bridge: fix netlink max attr size

From: <hidden>
Date: 2015-08-19 18:26:53

From: Scott Feldman <redacted>

.maxtype should match .policy.  Probably just been getting lucky here
because IFLA_BRPORT_MAX > IFLA_BR_MAX.

Fixes: 13323516 ("bridge: implement rtnl_link_ops->changelink")
Signed-off-by: Scott Feldman <redacted>
---
 net/bridge/br_netlink.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 01401ea..d2c4d66 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -849,7 +849,7 @@ struct rtnl_link_ops br_link_ops __read_mostly = {
 	.kind			= "bridge",
 	.priv_size		= sizeof(struct net_bridge),
 	.setup			= br_dev_setup,
-	.maxtype		= IFLA_BRPORT_MAX,
+	.maxtype		= IFLA_BR_MAX,
 	.policy			= br_policy,
 	.validate		= br_validate,
 	.newlink		= br_dev_newlink,
-- 
1.7.10.4

Re: [PATCH net-next] bridge: fix netlink max attr size

From: David Miller <davem@davemloft.net>
Date: 2015-08-20 21:38:49

From: sfeldma@gmail.com
Date: Wed, 19 Aug 2015 11:29:35 -0700
From: Scott Feldman <redacted>

.maxtype should match .policy.  Probably just been getting lucky here
because IFLA_BRPORT_MAX > IFLA_BR_MAX.

Fixes: 13323516 ("bridge: implement rtnl_link_ops->changelink")
Signed-off-by: Scott Feldman <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help