[PATCH] r8169:Fill with zero Tx descriptors

Subsystems: 8169 10/100/1000 gigabit ethernet driver, networking drivers, the rest

STALE4019d

3 messages, 3 authors, 2015-08-05 · open the first message on its own page

[PATCH] r8169:Fill with zero Tx descriptors

From: Corcodel Marian <hidden>
Date: 2015-08-05 10:46:59

 This patch fill with zero Tx descriptors before use.Is only
 on    part by more patches but is critical.(critical)


Signed-off-by: Corcodel Marian <redacted>

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3df51fa..bf78f94 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c

@@ -7589,7 +7589,7 @@ static int rtl_open(struct net_device *dev)
 	 * Rx and Tx descriptors needs 256 bytes alignment.
 	 * dma_alloc_coherent provides more.
 	 */
-	tp->TxDescArray = dma_alloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
+	tp->TxDescArray = dma_zalloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
 					     &tp->TxPhyAddr, GFP_KERNEL);
 	if (!tp->TxDescArray)
 		goto err_pm_runtime_put;

-- 
2.1.4

Re: [PATCH] r8169:Fill with zero Tx descriptors

From: Sergei Shtylyov <hidden>
Date: 2015-08-05 12:57:23

Hello.

On 8/5/2015 1:46 PM, Corcodel Marian wrote:

  This patch fill with zero Tx descriptors before use.Is only
  on    part by more patches but is critical.(critical)

Signed-off-by: Corcodel Marian <redacted>

quoted hunk

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3df51fa..bf78f94 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c

@@ -7589,7 +7589,7 @@ static int rtl_open(struct net_device *dev)
  	 * Rx and Tx descriptors needs 256 bytes alignment.
  	 * dma_alloc_coherent provides more.
  	 */
-	tp->TxDescArray = dma_alloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
+	tp->TxDescArray = dma_zalloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
  					     &tp->TxPhyAddr, GFP_KERNEL);

    Please re-align the continuation line.

[...]

MBR, Sergei

Re: [PATCH] r8169:Fill with zero Tx descriptors

From: Ivan Vecera <ivecera@redhat.com>
Date: 2015-08-05 13:42:37

On 5.8.2015 12:46, Corcodel Marian wrote:

quoted hunk

  This patch fill with zero Tx descriptors before use.Is only
  on    part by more patches but is critical.(critical)


Signed-off-by: Corcodel Marian <redacted>

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3df51fa..bf78f94 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c

@@ -7589,7 +7589,7 @@ static int rtl_open(struct net_device *dev)
  	 * Rx and Tx descriptors needs 256 bytes alignment.
  	 * dma_alloc_coherent provides more.
  	 */
-	tp->TxDescArray = dma_alloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
+	tp->TxDescArray = dma_zalloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
  					     &tp->TxPhyAddr, GFP_KERNEL);
  	if (!tp->TxDescArray)
  		goto err_pm_runtime_put;

Why? Why is zero-filling of tx-ring critical???

Ivan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help