[PATCH] xen-netback: remove duplicated function definition

Subsystems: networking drivers, the rest, xen network backend driver · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Wei Liu, Paul Durrant

STALE4131d

4 messages, 3 authors, 2015-07-05 · open the first message on its own page

[PATCH] xen-netback: remove duplicated function definition

From: Liang Li <hidden>
Date: 2015-07-03 07:42:16

There are two duplicated xenvif_zerocopy_callback() definitions.
Remove one of them.

Signed-off-by: Liang Li <redacted>
---
 drivers/net/xen-netback/common.h | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h
index 8a495b3..c6cb85a 100644
--- a/drivers/net/xen-netback/common.h
+++ b/drivers/net/xen-netback/common.h
@@ -325,9 +325,6 @@ static inline pending_ring_idx_t nr_pending_reqs(struct xenvif_queue *queue)
 		queue->pending_prod + queue->pending_cons;
 }
 
-/* Callback from stack when TX packet can be released */
-void xenvif_zerocopy_callback(struct ubuf_info *ubuf, bool zerocopy_success);
-
 irqreturn_t xenvif_interrupt(int irq, void *dev_id);
 
 extern bool separate_tx_rx_irq;
-- 
1.9.1

Re: [PATCH] xen-netback: remove duplicated function definition

From: David Miller <davem@davemloft.net>
Date: 2015-07-03 16:54:59

From: Liang Li <redacted>
Date: Sat,  4 Jul 2015 03:33:00 +0800
There are two duplicated xenvif_zerocopy_callback() definitions.
Remove one of them.

Signed-off-by: Liang Li <redacted>
You really need to fix the date on your computer.

If your date is in the future, as your's is, then your patch appears
out-of-order in the patchwork patch queue since it is ordered by the
Date: field in the email.

RE: [PATCH] xen-netback: remove duplicated function definition

From: Li, Liang Z <hidden>
Date: 2015-07-05 09:06:13

Cc: <redacted>; <redacted>;
wei.liu2@citrix.com; xen-devel@lists.xenproject.org;
netdev@vger.kernel.org
Subject: Re: [PATCH] xen-netback: remove duplicated function definition

From: Liang Li <redacted>
Date: Sat,  4 Jul 2015 03:33:00 +0800
quoted
There are two duplicated xenvif_zerocopy_callback() definitions.
Remove one of them.

Signed-off-by: Liang Li <redacted>
You really need to fix the date on your computer.

If your date is in the future, as your's is, then your patch appears out-of-
order in the patchwork patch queue since it is ordered by the
Date: field in the email.
OK. Thanks for your reminding.

Re: [PATCH] xen-netback: remove duplicated function definition

From: Wei Liu <hidden>
Date: 2015-07-05 19:48:32

On Sat, Jul 04, 2015 at 03:33:00AM +0800, Liang Li wrote:
There are two duplicated xenvif_zerocopy_callback() definitions.
Remove one of them.

Signed-off-by: Liang Li <redacted>
Acked-by: Wei Liu <redacted>

Please fix the time of your computer and resend.

Wei.
quoted hunk
---
 drivers/net/xen-netback/common.h | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h
index 8a495b3..c6cb85a 100644
--- a/drivers/net/xen-netback/common.h
+++ b/drivers/net/xen-netback/common.h
@@ -325,9 +325,6 @@ static inline pending_ring_idx_t nr_pending_reqs(struct xenvif_queue *queue)
 		queue->pending_prod + queue->pending_cons;
 }
 
-/* Callback from stack when TX packet can be released */
-void xenvif_zerocopy_callback(struct ubuf_info *ubuf, bool zerocopy_success);
-
 irqreturn_t xenvif_interrupt(int irq, void *dev_id);
 
 extern bool separate_tx_rx_irq;
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help