[PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast

Subsystems: networking [general], the rest

STALE4122d

2 messages, 2 authors, 2015-07-13 · open the first message on its own page

[PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast

From: Konstantin Khlebnikov <hidden>
Date: 2015-07-10 12:21:39

This patch clears skb->peeked set by previous recipient of broadcast.

Signed-off-by: Konstantin Khlebnikov <redacted>
Fixes: add05ad4e9f5 ("unix/dgram: peek beyond 0-sized skbs")
---
 net/netlink/af_netlink.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 921e0d8dfe3a..f4427f4bf223 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1967,6 +1967,7 @@ static void do_one_broadcast(struct sock *sk,
 			 * delivered to a previous socket.
 			 */
 			skb_orphan(p->skb2);
+			p->skb2->peeked = 0;
 		}
 	}
 	if (p->skb2 == NULL) {

Re: [PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-07-13 08:05:52

On Fri, Jul 10, 2015 at 03:21:34PM +0300, Konstantin Khlebnikov wrote:
This patch clears skb->peeked set by previous recipient of broadcast.

Signed-off-by: Konstantin Khlebnikov <redacted>
Fixes: add05ad4e9f5 ("unix/dgram: peek beyond 0-sized skbs")
Per my earlier email, this patch is not needed if we fix the root
cause.

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help