[PATCH net-next] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" for CONFIG_ACPI=n.

Subsystems: applied micro (apm) x-gene soc ethernet driver, networking drivers, the rest

STALE4085d

2 messages, 2 authors, 2015-07-08 · open the first message on its own page

[PATCH net-next] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" for CONFIG_ACPI=n.

From: Suman Tripathi <hidden>
Date: 2015-07-06 08:05:12

This patch guards the acpi_evaluate_interger function as it fails
the build for CONFIG_ACPI=n.

Signed-off-by: Iyappan Subramanian <redacted>
Signed-off-by: Suman Tripathi <redacted>
Reported-by: kbuild test robot <redacted>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 4e83d4c..70b9ef6 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -871,6 +871,7 @@ static const struct net_device_ops xgene_ndev_ops = {
 	.ndo_set_mac_address = xgene_enet_set_mac_address,
 };

+#ifdef CONFIG_ACPI
 static int xgene_get_port_id_acpi(struct device *dev,
 				  struct xgene_enet_pdata *pdata)
 {
@@ -886,6 +887,7 @@ static int xgene_get_port_id_acpi(struct device *dev,

 	return 0;
 }
+#endif

 static int xgene_get_port_id_dt(struct device *dev, struct xgene_enet_pdata *pdata)
 {
--
1.8.2.1

[PATCH net-next] drivers: net: xgene: Fix the compilation error "error: implicit declaration of function 'acpi_evaluate_integer'" for CONFIG_ACPI=n.

From: davem@davemloft.net (David Miller)
Date: 2015-07-08 21:44:57

From: Suman Tripathi <redacted>
Date: Mon,  6 Jul 2015 13:34:22 +0530
This patch guards the acpi_evaluate_interger function as it fails
the build for CONFIG_ACPI=n.

Signed-off-by: Iyappan Subramanian <redacted>
Signed-off-by: Suman Tripathi <redacted>
Reported-by: kbuild test robot <redacted>
While the net-next tree is closed, all work and bug fixes should occur against
'net' which trumps the 'net-next' tree during this time.

If you had investigated, you would have seen that this build failure had
been fixed in the 'net' tree for some time now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help