# \[PATCH net-next 4/6\] net\_sched: act: use a separate packet counters for gact\_determ() - From: Eric Dumazet \ - Date: 2015-07-02 13:08:42 - List: netdev - Page: https://ratatoskr.run/netdev/2015/07/10991012 - Thread: https://ratatoskr.run/netdev/2015/07/10991009/t.md ```text Second step for gact RCU operation : We want to get rid of the spinlock protecting gact operations. Stats (packets/bytes) will soon be per cpu. gact_determ() would not work without a central packet counter, so lets add it for this mode. Signed-off-by: Eric Dumazet Cc: Alexei Starovoitov Cc: Jamal Hadi Salim Cc: John Fastabend --- include/net/tc_act/tc_gact.h | 7 ++++--- net/sched/act_gact.c | 4 +++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/include/net/tc_act/tc_gact.h b/include/net/tc_act/tc_gact.h index 9fc9b578908a..592a6bc02b0b 100644 --- a/include/net/tc_act/tc_gact.h +++ b/include/net/tc_act/tc_gact.h @@ -6,9 +6,10 @@ struct tcf_gact { struct tcf_common common; #ifdef CONFIG_GACT_PROB - u16 tcfg_ptype; - u16 tcfg_pval; - int tcfg_paction; + u16 tcfg_ptype; + u16 tcfg_pval; + int tcfg_paction; + atomic_t packets; #endif }; #define to_gact(a) \ diff --git a/net/sched/act_gact.c b/net/sched/act_gact.c index 42284aad77dd..e968290e8378 100644 --- a/net/sched/act_gact.c +++ b/net/sched/act_gact.c @@ -35,7 +35,9 @@ static int gact_net_rand(struct tcf_gact *gact) static int gact_determ(struct tcf_gact *gact) { - if (gact->tcf_bstats.packets % gact->tcfg_pval) + u32 pack = atomic_inc_return(&gact->packets); + + if (pack % gact->tcfg_pval) return gact->tcf_action; return gact->tcfg_paction; } -- 2.4.3.573.g4eafbef ```