# Re: \[PATCH 19/22\] fjes: update\_zone\_task

- From: Joe Perches \<joe@perches.com\>
- Date: 2015-06-18 02:25:07 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/06/8977330
- Thread: https://ratatoskr.run/platform-driver-x86/2015/06/8977304/t.md

```text
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote:
> This patch adds update_zone_task.

> diff --git a/drivers/platform/x86/fjes/fjes_hw.c b/drivers/platform/x86/fjes/fjes_hw.c
[]
> +static void fjes_hw_update_zone_task(struct work_struct *work)
> +{

Some of the line length can be removed here by using a
temporary, but these would look a lot better if you went
beyond 80 columns.

	info = &res_buf->info.info;
[]
> +				case EP_PARTNER_UNSHARE:
> +				default:
> +					if ((res_buf->info.info[epidx].zone !=
> +						FJES_ZONING_ZONE_TYPE_NONE) &&
> +					    (res_buf->info.info[epidx].es_status ==
> +						FJES_ZONING_STATUS_ENABLE) &&
> +					    (res_buf->info.info[epidx].zone ==
> +						res_buf->info.info[hw->my_epid].zone))

So these become
					if ((info[epidx].zone != FJES_ZONING_ZONE_TYPE_NONE) &&
					    (info[epidx].es_status == FJES_ZONING_STATUS_ENABLE) &&
					    (info[epidx].zone == info[hw->my_epid.zone))

> +				case EP_PARTNER_COMPLETE:
> +				case EP_PARTNER_WAITING:
> +					if ((res_buf->info.info[epidx].zone ==
> +						FJES_ZONING_ZONE_TYPE_NONE) ||
> +					    (res_buf->info.info[epidx].es_status !=
> +						FJES_ZONING_STATUS_ENABLE) ||
> +					    (res_buf->info.info[epidx].zone !=
> +						res_buf->info.
> +						  info[hw->my_epid].zone)) {

etc...
```