[PATCH 1/1] ssb: remove unncessary out label
Subsystems:
sonics silicon backplane driver (ssb), the rest
STALE4073d
REVIEWED: 1 (0M)
1 review trailer.
2 messages,
2 authors,
2015-06-19 · open the first message on its own page
This patch removes unnecessary label "out" and
some restructring for using device_create_file directly.
Signed-off-by: Maninder Singh <redacted>
Reviewed-by: Rohit Thapliyal <redacted>
---
drivers/ssb/pci.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 0f28c08..d6ca4d3 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -1173,17 +1173,11 @@ void ssb_pci_exit(struct ssb_bus *bus)
int ssb_pci_init(struct ssb_bus *bus)
{
struct pci_dev *pdev;
- int err;
if (bus->bustype != SSB_BUSTYPE_PCI)
return 0;
pdev = bus->host_pci;
mutex_init(&bus->sprom_mutex);
- err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
- if (err)
- goto out;
-
-out:
- return err;
+ return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
}--
1.7.1
On Fri, 19 Jun 2015 14:23:45 +0530
Maninder Singh [off-list ref] wrote:
quoted hunk
This patch removes unnecessary label "out" and
some restructring for using device_create_file directly.
Signed-off-by: Maninder Singh <redacted>
Reviewed-by: Rohit Thapliyal <redacted>
---
drivers/ssb/pci.c | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
index 0f28c08..d6ca4d3 100644
--- a/drivers/ssb/pci.c
+++ b/drivers/ssb/pci.c
@@ -1173,17 +1173,11 @@ void ssb_pci_exit(struct ssb_bus *bus)
int ssb_pci_init(struct ssb_bus *bus)
{
struct pci_dev *pdev;
- int err;
if (bus->bustype != SSB_BUSTYPE_PCI)
return 0;
pdev = bus->host_pci;
mutex_init(&bus->sprom_mutex);
- err = device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
- if (err)
- goto out;
-
-out:
- return err;
+ return device_create_file(&pdev->dev, &dev_attr_ssb_sprom);
}
I don't really think this change adds any value, but if you insist on
it you get my acked-by.
--
Michael