[PATCH] pkt_sched: sch_qfq: remove redundant -if- control statement

Subsystems: networking [general], tc subsystem, the rest

STALE4076d

2 messages, 2 authors, 2015-06-16 · open the first message on its own page

[PATCH] pkt_sched: sch_qfq: remove redundant -if- control statement

From: Andrea Parri <parri.andrea@gmail.com>
Date: 2015-06-15 12:20:16

The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary
because already performed in hlist_del_init(), so remove it.

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
---
 net/sched/sch_qfq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index 3ec7e88..b8d73bc 100644
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -339,8 +339,7 @@ static struct qfq_aggregate *qfq_choose_next_agg(struct qfq_sched *);
 
 static void qfq_destroy_agg(struct qfq_sched *q, struct qfq_aggregate *agg)
 {
-       if (!hlist_unhashed(&agg->nonfull_next))
-               hlist_del_init(&agg->nonfull_next);
+       hlist_del_init(&agg->nonfull_next);
        q->wsum -= agg->class_weight;
        if (q->wsum != 0)
                q->iwsum = ONE_FP / q->wsum;

Re: [PATCH] pkt_sched: sch_qfq: remove redundant -if- control statement

From: David Miller <davem@davemloft.net>
Date: 2015-06-16 00:20:18

From: Andrea Parri <parri.andrea@gmail.com>
Date: Mon, 15 Jun 2015 14:20:01 +0200
The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary
because already performed in hlist_del_init(), so remove it.

Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
This patch has been corrupted by your email client (TAB characters
have been transformed into sequences of SPACEs, etc.)

Please fix this up and resubmit.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help