[PATCH] ethernet: micrel: use time_after_eq macro

use time_after_eq macro for time comparison

Signed-off-by: Antonio Murdaca <redacted>
---
 drivers/net/ethernet/micrel/ksz884x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 48d2aec..9bce30c 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c

@@ -6689,7 +6689,7 @@ static void mib_monitor(unsigned long ptr)
 
 	/* This is used to verify Wake-on-LAN is working. */
 	if (hw_priv->pme_wait) {
-		if (hw_priv->pme_wait <= jiffies) {
+		if (time_after_eq(jiffies, hw_priv->pme_wait)) {
 			hw_clr_wol_pme_status(&hw_priv->hw);
 			hw_priv->pme_wait = 0;
 		}

-- 
2.4.2

On Fri, 5 Jun 2015, Antonio Murdaca wrote:

There is also time_is_before_eq_jiffies.

julia

 			hw_clr_wol_pme_status(&hw_priv->hw);
 			hw_priv->pme_wait = 0;
 		}
--
2.4.2

I'll use that then and resubmit this patch

Thanks

2015-06-05 17:45 GMT+02:00 Julia Lawall [off-list ref]:

On Fri, 5 Jun 2015, Antonio Murdaca wrote:

quoted

use time_after_eq macro for time comparison

Signed-off-by: Antonio Murdaca <redacted>
---
 drivers/net/ethernet/micrel/ksz884x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 48d2aec..9bce30c 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c

@@ -6689,7 +6689,7 @@ static void mib_monitor(unsigned long ptr)

      /* This is used to verify Wake-on-LAN is working. */
      if (hw_priv->pme_wait) {
-             if (hw_priv->pme_wait <= jiffies) {
+             if (time_after_eq(jiffies, hw_priv->pme_wait)) {

There is also time_is_before_eq_jiffies.

julia

quoted

                      hw_clr_wol_pme_status(&hw_priv->hw);
                      hw_priv->pme_wait = 0;
              }
--
2.4.2

-- 
Antonio Murdaca