Re: [PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac
From: Or Gerlitz <hidden>
Date: 2015-06-02 05:58:25
On Mon, Jun 1, 2015 at 5:41 PM, [off-list ref] wrote:
quoted hunk
fix typo in mlx4_set_vf_mac Signed-off-by: Carol L Soto <redacted> --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)--- a/drivers/net/ethernet/mellanox/mlx4/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx4/cmd.c@@ -2687,7 +2687,7 @@ int mlx4_set_vf_mac(struct mlx4_dev *dev port = mlx4_slaves_closest_port(dev, slave, port); s_info = &priv->mfunc.master.vf_admin[slave].vport[port]; s_info->mac = mac; - mlx4_info(dev, "default mac on vf %d port %d to %llX will take afect only after vf restart\n", + mlx4_info(dev, "default mac on vf %d port %d to %llX will take effect only after vf restart\n", vf, port, s_info->mac); return 0; }
Hi Carol, Thanks for the fixes, will look on the other two today and provide feedback. As for this one: please re-send the patch and target it to net-next (i.e have [PATCH net-next] on the subject line and generate it against the net-next tree git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git). Also, we use some conventions in our commits, will be happy if you can pick on them: -- have "net/mlx4_core:" prefix -- use capital letter in the 1st word of the subject line, that is so [PATCH net] net/mlx4: fix typo in mlx4_set_vf_mac becomes [PATCH net-next] net/mlx4_core: Fix typo in mlx4_set_vf_mac You can add my ack Acked-by: Or Gerlitz <redacted> Or.