# Re: \[PATCH v5\] net: phy: micrel: Fix regression in kszphy\_probe

- From: David Miller \<davem@davemloft.net\>
- Date: 2015-05-13 03:19:15 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/05/4492187
- Thread: https://ratatoskr.run/netdev/2015/05/4491232/t.md

```text
From: Niklas Cassel <redacted>
Date: Tue, 12 May 2015 09:43:14 +0200

> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
> 
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
> 
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
> 
> Cc: stable <redacted> # 3.18+
> Fixes: 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")
> Reviewed-by: Fabio Estevam <redacted>
> Reviewed-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Niklas Cassel <redacted>

Applied, thank you.
```
