DORMANTno replies

Revision v2 of 2 in this series.

Revisions (2)
  1. v2 current
  2. v3 [diff vs current]

[PATCH net v2 0/2] mpls: fix route del errors on wrong scope and type

From: Roopa Prabhu <hidden>
Date: 2015-05-27 18:37:10

From: Roopa Prabhu <redacted>

This patch fixes incorrect -EINVAL errors due to invalid
scope and type during mpls route deletes.

$ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1
RTNETLINK answers: Invalid argument

$ip -f mpls route del 100
RTNETLINK answers: Invalid argument

After patch:

$ip -f mpls route show
100 as to 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route del 100 as 200 via inet 10.1.1.2 dev swp1

$ip -f mpls route show

Reported-by: Vivek Venkataraman <redacted>
Signed-off-by: Vivek Venkataraman <redacted>
Signed-off-by: Roopa Prabhu <redacted>

v2: split the fix between iproute2 and kernel as suggested by
	Eric Biederman

Roopa Prabhu (2):
  iproute2: mpls: always set type as RTN_UNICAST for route
  mpls: fix mpls route deletes to not check for route scope

 net/mpls/af_mpls.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

-- 
1.7.10.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help