[jkirsher-next-queue:dev-queue 828/842] drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static?

3 messages, 2 authors, 2015-03-19 · open the first message on its own page

[jkirsher-next-queue:dev-queue 828/842] drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static?

From: kbuild test robot <hidden>
Date: 2015-03-19 00:52:10

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
head:   ec59d04e8f5223083fdfb6124e8f087c1a4c5ec2
commit: c10e4fc6c45616dbadb8ccee189e2c09fb8f056f [828/842] net/mlx4_en: Add tx queue maxrate support
reproduce:
  # apt-get install sparse
  git checkout c10e4fc6c45616dbadb8ccee189e2c09fb8f056f
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)
quoted
drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2382:5: sparse: symbol 'mlx4_en_set_tx_maxrate' was not declared. Should it be static?
Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static

From: kbuild test robot <hidden>
Date: 2015-03-19 00:52:12

Signed-off-by: Fengguang Wu <redacted>
---
 en_netdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index d8dc3f9..763ba26 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2379,7 +2379,7 @@ static netdev_features_t mlx4_en_features_check(struct sk_buff *skb,
 }
 #endif
 
-int mlx4_en_set_tx_maxrate(struct net_device *dev, int queue_index, u32 maxrate)
+static int mlx4_en_set_tx_maxrate(struct net_device *dev, int queue_index, u32 maxrate)
 {
 	struct mlx4_en_priv *priv = netdev_priv(dev);
 	struct mlx4_en_tx_ring *tx_ring = priv->tx_ring[queue_index];

Re: [PATCH jkirsher-next-queue] net/mlx4_en: mlx4_en_set_tx_maxrate() can be static

From: David Miller <davem@davemloft.net>
Date: 2015-03-19 03:22:01

From: kbuild test robot <redacted>
Date: Thu, 19 Mar 2015 08:51:27 +0800
Signed-off-by: Fengguang Wu <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help