[PATCH] net: add comment for sock_efree() usage

Subsystems: networking [general], networking [sockets], the rest

STALE4174d

3 messages, 3 authors, 2015-03-10 · open the first message on its own page

[PATCH] net: add comment for sock_efree() usage

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2015-03-10 18:04:03

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
 net/core/sock.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/net/core/sock.c b/net/core/sock.c
index 93c8b20..78e89eb 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1655,6 +1655,10 @@ void sock_rfree(struct sk_buff *skb)
 }
 EXPORT_SYMBOL(sock_rfree);
 
+/*
+ * Buffer destructor for skbs that are not used directly in read or write
+ * path, e.g. for error handler skbs. Automatically called from kfree_skb.
+ */
 void sock_efree(struct sk_buff *skb)
 {
 	sock_put(skb->sk);
-- 
2.1.4

Re: [PATCH] net: add comment for sock_efree() usage

From: Alexander Duyck <hidden>
Date: 2015-03-10 18:32:30

On 03/10/2015 11:03 AM, Oliver Hartkopp wrote:
quoted hunk
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
  net/core/sock.c | 4 ++++
  1 file changed, 4 insertions(+)
diff --git a/net/core/sock.c b/net/core/sock.c
index 93c8b20..78e89eb 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1655,6 +1655,10 @@ void sock_rfree(struct sk_buff *skb)
  }
  EXPORT_SYMBOL(sock_rfree);
  
+/*
+ * Buffer destructor for skbs that are not used directly in read or write
+ * path, e.g. for error handler skbs. Automatically called from kfree_skb.
+ */
  void sock_efree(struct sk_buff *skb)
  {
  	sock_put(skb->sk);
Acked-by: Alexander Duyck <redacted>

Re: [PATCH] net: add comment for sock_efree() usage

From: David Miller <davem@davemloft.net>
Date: 2015-03-10 20:12:39

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Tue, 10 Mar 2015 19:03:46 +0100
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help