Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

2 messages, 2 authors, 2015-02-24 · open the first message on its own page

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2015-02-24 10:33:20

I have no idea about NFC, but 
quoted hunk
+config NFC_FDP
+	tristate "Intel FDP NFC driver"
+	depends on NFC_NCI
+	select CRC_CCITT
+	default n
+	---help---
+	  Intel FDP core driver.
+	  This is a driver based on the NCI NFC kernel layers.
+
+	  To compile this driver as a module, choose m here. The module will
+	  be called pn547.
this seems like a copy/paste error? Certainly it's called fdp?

johannes

Re: [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

From: Robert Dolca <hidden>
Date: 2015-02-24 10:46:56

On Tue, Feb 24, 2015 at 11:33:10AM +0100, Johannes Berg wrote:
quoted
+config NFC_FDP
+	tristate "Intel FDP NFC driver"
+	depends on NFC_NCI
+	select CRC_CCITT
+	default n
+	---help---
+	  Intel FDP core driver.
+	  This is a driver based on the NCI NFC kernel layers.
+
+	  To compile this driver as a module, choose m here. The module will
+	  be called pn547.
this seems like a copy/paste error? Certainly it's called fdp?
You are right. It should be FDP instead of pn547.

I will also rename the menu entry name from "Intel FDP NFC driver" to
"Intel FieldsPeak (FDP) NFC driver" to be more clear what FDP means.

Thanks,
Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help