[PATCH] myri10ge: Delete an unnecessary check before the function call "kfree"

Subsystems: myricom myri-10g 10gbe driver (myri10ge), networking drivers, the rest

STALE4278d

2 messages, 2 authors, 2015-02-05 · open the first message on its own page

[PATCH] myri10ge: Delete an unnecessary check before the function call "kfree"

From: SF Markus Elfring <hidden>
Date: 2015-02-04 11:36:09

From: Markus Elfring <redacted>
Date: Wed, 4 Feb 2015 12:32:14 +0100

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 71af98b..1412f5a 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -4226,8 +4226,7 @@ static void myri10ge_remove(struct pci_dev *pdev)
 		mtrr_del(mgp->mtrr, mgp->iomem_base, mgp->board_span);
 #endif
 	myri10ge_free_slices(mgp);
-	if (mgp->msix_vectors != NULL)
-		kfree(mgp->msix_vectors);
+	kfree(mgp->msix_vectors);
 	dma_free_coherent(&pdev->dev, sizeof(*mgp->cmd),
 			  mgp->cmd, mgp->cmd_bus);
 
-- 
2.2.2

Re: [PATCH] myri10ge: Delete an unnecessary check before the function call "kfree"

From: David Miller <davem@davemloft.net>
Date: 2015-02-05 08:25:33

From: SF Markus Elfring <redacted>
Date: Wed, 04 Feb 2015 12:36:02 +0100
From: Markus Elfring <redacted>
Date: Wed, 4 Feb 2015 12:32:14 +0100

The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help