@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (err) dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n", err);+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set this state * before setting up the misc vector or we get a race and the vector * ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded a
couple of hundred times. Would it be safe to just remove this hunk?
I haven't seen any negative effects by removing this yet.
Stefan
@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (err) dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n", err);+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set this state * before setting up the misc vector or we get a race and the vector * ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded a
couple of hundred times. Would it be safe to just remove this hunk?
I haven't seen any negative effects by removing this yet.
Stefan
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
Stefan,
I wouldn't remove them yet as this does look like a valid idea to check to see if the link is
restarting successfully. On the other hand can you try removing the msleep line as this one is
most likely causing the issue due to sleeping for some long in a probe function is generally a
bad idea.
Thanks,
Nick
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (err) dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n", err);+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set this state * before setting up the misc vector or we get a race and the vector * ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded a
couple of hundred times. Would it be safe to just remove this hunk?
I haven't seen any negative effects by removing this yet.
Stefan
Stefan,
I wouldn't remove them yet as this does look like a valid idea to check to see if the link is
restarting successfully. On the other hand can you try removing the msleep line as this one is
most likely causing the issue due to sleeping for some long in a probe function is generally a
bad idea.
Thanks,
Nick
Thanks Nick for the quick reply. I tested removing the msleep but that
didn't make a difference. You actually need to remove the complete hunk
to get a stable driver reload.
Stefan
@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) if (err) dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n", err);+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set this state * before setting up the misc vector or we get a race and the vector * ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded a
couple of hundred times. Would it be safe to just remove this hunk?
I haven't seen any negative effects by removing this yet.
Stefan
Stefan,
I wouldn't remove them yet as this does look like a valid idea to check to see if the link is
restarting successfully. On the other hand can you try removing the msleep line as this one is
most likely causing the issue due to sleeping for some long in a probe function is generally a
bad idea.
Thanks,
Nick
Thanks Nick for the quick reply. I tested removing the msleep but that
didn't make a difference. You actually need to remove the complete hunk
to get a stable driver reload.
Stefan
Stefan,
Basically there are a few things that could be going wrong
1. You are getting a error return for the function,i40e_aq_set_link_restart_an
2. You are trying to re able the device again when not needed
3. You are sending a NULL value to a field for command arguments that takes a 0 and not NULL
to take no arguments
Nick
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev *pdev,
const struct pci_device_id *ent)
quoted
quoted
quoted
if (err)
dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n",
err);
quoted
quoted
quoted
+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set this
state
quoted
quoted
quoted
* before setting up the misc vector or we get a race and the
vector
quoted
quoted
quoted
* ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded a
couple of hundred times. Would it be safe to just remove this hunk?
I haven't seen any negative effects by removing this yet.
Stefan
Stefan,
I wouldn't remove them yet as this does look like a valid idea to
check to see if the link is
quoted
quoted
restarting successfully. On the other hand can you try removing the
msleep line as this one is
quoted
quoted
most likely causing the issue due to sleeping for some long in a
probe function is generally a
quoted
quoted
bad idea.
Thanks,
Nick
Thanks Nick for the quick reply. I tested removing the msleep but that
didn't make a difference. You actually need to remove the complete
hunk
quoted
to get a stable driver reload.
Stefan
Stefan,
Basically there are a few things that could be going wrong
1. You are getting a error return for the
function,i40e_aq_set_link_restart_an
2. You are trying to re able the device again when not needed
3. You are sending a NULL value to a field for command arguments that
takes a 0 and not NULL
to take no arguments
Nick
First of all, I would make sure you've got a short sleep in between each load and unload in this stress test. There's a lot going on under the covers in the Firmware that really should be allowed to settle out before jostling it again with another load/unload command.
It would help to know what Firmware you have on your NIC - can you give us the output from "ethtool -i <ethX>"?
The out-of-tree driver has just (finally!) been updated on SourceForge, so you might give this version 1.2.37 driver a try to see if it changes your result. That code still has the hunk in question, but protected by a FW version check. The related patch will be headed upstream to net-next very soon.
Firmware updates have also just been released, but I'm not sure they've made it to the Intel Downloads site yet. Updating your FW will make a difference.
sln
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev
*pdev,
quoted
const struct pci_device_id *ent)
quoted
quoted
quoted
if (err)
dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n",
err);
quoted
quoted
quoted
+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set
this
quoted
state
quoted
quoted
quoted
* before setting up the misc vector or we get a race and the
vector
quoted
quoted
quoted
* ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded
a
quoted
quoted
quoted
quoted
couple of hundred times. Would it be safe to just remove this
hunk?
quoted
quoted
quoted
quoted
I haven't seen any negative effects by removing this yet.
Stefan
Stefan,
I wouldn't remove them yet as this does look like a valid idea to
check to see if the link is
quoted
quoted
restarting successfully. On the other hand can you try removing
the
quoted
msleep line as this one is
quoted
quoted
most likely causing the issue due to sleeping for some long in a
probe function is generally a
quoted
quoted
bad idea.
Thanks,
Nick
Thanks Nick for the quick reply. I tested removing the msleep but
that
quoted
quoted
didn't make a difference. You actually need to remove the complete
hunk
quoted
to get a stable driver reload.
Stefan
Stefan,
Basically there are a few things that could be going wrong
1. You are getting a error return for the
function,i40e_aq_set_link_restart_an
2. You are trying to re able the device again when not needed
3. You are sending a NULL value to a field for command arguments that
takes a 0 and not NULL
to take no arguments
Nick
First of all, I would make sure you've got a short sleep in between
each load and unload in this stress test. There's a lot going on under
the covers in the Firmware that really should be allowed to settle out
before jostling it again with another load/unload command.
It would help to know what Firmware you have on your NIC - can you give
us the output from "ethtool -i <ethX>"?
The out-of-tree driver has just (finally!) been updated on SourceForge,
so you might give this version 1.2.37 driver a try to see if it changes
your result. That code still has the hunk in question, but protected
by a FW version check. The related patch will be headed upstream to
net-next very soon.
Firmware updates have also just been released, but I'm not sure they've
made it to the Intel Downloads site yet. Updating your FW will make a
difference.
sln
Thanks Shannon,
For the advice on there being a newer driver and firmware to test that on before reporting the bug against this driver. I am curious as to why this newer code is not up streamed to Linux next yet through.
Nick
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
From: Jeff Kirsher <hidden> Date: 2015-02-28 00:45:59
On Fri, 2015-02-27 at 16:25 -0500, Nicholas Krause wrote:
Thanks Shannon,
For the advice on there being a newer driver and firmware to test that
on before reporting the bug against this driver. I am curious as to
why this newer code is not up streamed to Linux next yet through.
Because I still have ~40 patches in my queue for i40e that need to go
upstream to get the upstream driver in sync with our out-of-tree driver.
Also Nick, please do not take advantage of me being nice to you and
letting you remain on e1000-devel mailing list, even though you have
been banned on @vger.kernel.org mailing lists. It is clear from your
attempts to help Stefan, you do not know the driver and your "blind
stabs in the dark" to assist, only hinder our abilities to assist
others.
From: Nicholas Krause <hidden> Date: 2015-02-28 02:11:07
On February 27, 2015 7:45:58 PM EST, Jeff Kirsher [off-list ref] wrote:
On Fri, 2015-02-27 at 16:25 -0500, Nicholas Krause wrote:
quoted
Thanks Shannon,
For the advice on there being a newer driver and firmware to test
that
quoted
on before reporting the bug against this driver. I am curious as to
why this newer code is not up streamed to Linux next yet through.
Because I still have ~40 patches in my queue for i40e that need to go
upstream to get the upstream driver in sync with our out-of-tree
driver.
Also Nick, please do not take advantage of me being nice to you and
letting you remain on e1000-devel mailing list, even though you have
been banned on @vger.kernel.org mailing lists. It is clear from your
attempts to help Stefan, you do not know the driver and your "blind
stabs in the dark" to assist, only hinder our abilities to assist
others.
Jeff,
These seem to be the most likely culprits after reading the code. However there seems to be something else going wrong with the function call in the trace code. Jeff I do understand your busy with the upstream merging of the Intel drivers and was just wondering when the merge would be finished. Furthermore I can
try tracing this later during my March
Break. I do appreciate you being nice to me and am sorry about making you lose
your patience. I am interested in learning about the Intel network drivers and working with them, if would like to give me something to start with.
Sorry,
Nick :(
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
@@ -9169,6 +9178,13 @@ static int i40e_probe(struct pci_dev *pdev,
const struct pci_device_id *ent)
quoted
quoted
quoted
if (err)
dev_info(&pf->pdev->dev, "set phy mask fail, aq_err %d\n",
err);
quoted
quoted
quoted
+ msleep(75);+ err = i40e_aq_set_link_restart_an(&pf->hw, true, NULL);+ if (err) {+ dev_info(&pf->pdev->dev, "link restart failed, aq_err=%d\n",+ pf->hw.aq.asq_last_status);+ }+ /* The main driver is (mostly) up and happy. We need to set this
state
quoted
quoted
quoted
* before setting up the misc vector or we get a race and the
vector
quoted
quoted
quoted
* ends up disabled forever.
With this hunk removed the driver successfully unloaded/reloaded a
couple of hundred times. Would it be safe to just remove this hunk?
I haven't seen any negative effects by removing this yet.
Stefan
Stefan,
I wouldn't remove them yet as this does look like a valid idea to
check to see if the link is
quoted
quoted
restarting successfully. On the other hand can you try removing the
msleep line as this one is
quoted
quoted
most likely causing the issue due to sleeping for some long in a
probe function is generally a
quoted
quoted
bad idea.
Thanks,
Nick
Thanks Nick for the quick reply. I tested removing the msleep but that
didn't make a difference. You actually need to remove the complete
hunk
quoted
to get a stable driver reload.
Stefan
Stefan,
Basically there are a few things that could be going wrong
1. You are getting a error return for the
function,i40e_aq_set_link_restart_an
2. You are trying to re able the device again when not needed
3. You are sending a NULL value to a field for command arguments that
takes a 0 and not NULL
to take no arguments
Nick
First of all, I would make sure you've got a short sleep in between each load and unload in this stress test. There's a lot going on under the covers in the Firmware that really should be allowed to settle out before jostling it again with another load/unload command.
If a short delay is needed I think this should be implemented by the
driver. Triggering this kind of bug from userspace shouldn't be
possible. I'm using this reload loop regularly on driver backports to
test for regressions.
Btw, I noticed this problem during a normal reboot and used the
reloading while looking for a reproducer.
It would help to know what Firmware you have on your NIC - can you give us the output from "ethtool -i <ethX>"?
The out-of-tree driver has just (finally!) been updated on SourceForge, so you might give this version 1.2.37 driver a try to see if it changes your result. That code still has the hunk in question, but protected by a FW version check. The related patch will be headed upstream to net-next very soon.
1.2.37 fails the same way.
Firmware updates have also just been released, but I'm not sure they've made it to the Intel Downloads site yet. Updating your FW will make a difference.
If you could point me to the firmware updates and instructions I can
perform the update.
Thanks!
Stefan