# Re: \[PATCH v2 1/2\] rhashtable: require max\_shift if grow\_decision defined

- From: Thomas Graf \<tgraf@suug.ch\>
- Date: 2015-02-24 22:49:18 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/02/10978823
- Thread: https://ratatoskr.run/netfilter-devel/2015/02/10978719/t.md

```text
On 02/24/15 at 04:31pm, David Miller wrote:
> From: Daniel Borkmann <daniel@iogearbox.net>
> > Fwiw, I believe this behavior came in as a regression via commit
> > c0c09bfdc415 ("rhashtable: avoid unnecessary wakeup for worker
> > queue").
> > Initially, if no max_shift was specified, we'd just expand further.
> >
> > I can take care of these above two fixups tomorrow, if you want.

Thanks!

> > I presume you want to route both via -net, or just the growth limit
> > issue via -net?
> 
> Let's fix as much crap as we can in -net.  I'm going to have to do
> a huge backport of all the rhashtables to -stable at some point
> too.

All fixes except 2-3 should only affect the post per bucket lock
era. The fixes tags should be correct but I'll double check. I can
take care of the backports if you like.
```