[PATCH net-next] xfrm6: Fix a offset value for network header in _decode_session6

Subsystems: networking [general], networking [ipsec], the rest

STALE4277d

3 messages, 3 authors, 2015-02-06 · open the first message on its own page

[PATCH net-next] xfrm6: Fix a offset value for network header in _decode_session6

From: Hajime Tazaki <hidden>
Date: 2015-02-04 14:41:26

When a network-layer header has multiple IPv6 extension headers, then offset
for mobility header goes wrong. This regression breaks an xfrm policy lookup
for a particular receive packet. Binding update packets of Mobile IPv6
are all discarded without this fix.

Fixes: de3b7a06dfe1 ("xfrm6: Fix transport header offset in _decode_session6.")
Signed-off-by: Hajime Tazaki <redacted>
---
 net/ipv6/xfrm6_policy.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index 48bf5a0..8d2d01b 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -200,6 +200,7 @@ _decode_session6(struct sk_buff *skb, struct flowi *fl, int reverse)
 
 #if IS_ENABLED(CONFIG_IPV6_MIP6)
 		case IPPROTO_MH:
+			offset += ipv6_optlen(exthdr);
 			if (!onlyproto && pskb_may_pull(skb, nh + offset + 3 - skb->data)) {
 				struct ip6_mh *mh;
 
-- 
2.1.0

Re: [PATCH net-next] xfrm6: Fix a offset value for network header in _decode_session6

From: David Miller <davem@davemloft.net>
Date: 2015-02-05 23:38:54

From: Hajime Tazaki <redacted>
Date: Wed, 04 Feb 2015 23:31:10 +0900
When a network-layer header has multiple IPv6 extension headers, then offset
for mobility header goes wrong. This regression breaks an xfrm policy lookup
for a particular receive packet. Binding update packets of Mobile IPv6
are all discarded without this fix.

Fixes: de3b7a06dfe1 ("xfrm6: Fix transport header offset in _decode_session6.")
Signed-off-by: Hajime Tazaki <redacted>
Steffen, please review and/or integrate into your tree.

Thanks.

Re: [PATCH net-next] xfrm6: Fix a offset value for network header in _decode_session6

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2015-02-06 09:16:10

On Thu, Feb 05, 2015 at 03:38:54PM -0800, David Miller wrote:
From: Hajime Tazaki <redacted>
Date: Wed, 04 Feb 2015 23:31:10 +0900
quoted
When a network-layer header has multiple IPv6 extension headers, then offset
for mobility header goes wrong. This regression breaks an xfrm policy lookup
for a particular receive packet. Binding update packets of Mobile IPv6
are all discarded without this fix.

Fixes: de3b7a06dfe1 ("xfrm6: Fix transport header offset in _decode_session6.")
Signed-off-by: Hajime Tazaki <redacted>
Steffen, please review and/or integrate into your tree.
Now applied to the ipsec tree, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help