# Re: netfilter: Use rhashtable walk iterator

- From: Patrick McHardy \<hidden\>
- Date: 2015-02-01 07:45:27 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/02/10976884
- Thread: https://ratatoskr.run/netdev/2015/01/10975759/t/2.md

```text
On 31.01, Herbert Xu wrote:
> On Sat, Jan 31, 2015 at 02:13:56PM +1100, Herbert Xu wrote:
> > 
> > No problems.  Here is a new version of these two patches which
> > hopefully should work on netfilter as well.
> 
> And here is the patch for netfilter.
> 
> -- >8 --
> This patch gets rid of the manual rhashtable walk in nft_hash
> which touches rhashtable internals that should not be exposed.
> It does so by using the rhashtable iterator primitives.
>     
> Note that I'm leaving nft_hash_destroy alone since it's only
> invoked on shutdown and it shouldn't be affected by changes
> to rhashtable internals (or at least not what I'm planning to
> change).
>     
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Patrick McHardy <redacted>

Thanks Herbert!
```
