[PATCH] net: ieee802154: cc2520: Fix coding style issues

Subsystems: cc2520 ieee-802.15.4 radio driver, ieee 802.15.4 subsystem, networking drivers, the rest

STALE4225d

4 messages, 3 authors, 2015-01-23 · open the first message on its own page

[PATCH] net: ieee802154: cc2520: Fix coding style issues

From: Mohammad Jamal <hidden>
Date: 2015-01-23 09:31:06

This patch solves the coding style issues such as space after ,
and removes the blank lines

Signed-off-by: Mohammad Jamal <redacted>
---
 drivers/net/ieee802154/cc2520.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index f9df9fa..dd129be 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -513,7 +513,6 @@ err_tx:
 	return rc;
 }
 
-
 static int cc2520_rx(struct cc2520_private *priv)
 {
 	u8 len = 0, lqi = 0, bytes = 1;
@@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
 	u8 rssi;
 	int ret;
 
-	ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
+	ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
 	if (ret)
 		return ret;
 
 	if (status != RSSI_VALID)
 		return -EINVAL;
 
-	ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
+	ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
 	if (ret)
 		return ret;
 
@@ -947,7 +946,6 @@ static int cc2520_probe(struct spi_device *spi)
 	if (ret)
 		goto err_hw_init;
 
-
 	gpio_set_value(pdata->vreg, HIGH);
 	usleep_range(100, 150);
 
-- 
1.7.9.5

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

From: Varka Bhadram <hidden>
Date: 2015-01-23 09:39:36

Hi Mohammad Jamal,

These changes already there in the current bluetooth-next tree.

On Fri, Jan 23, 2015 at 2:56 PM, Mohammad Jamal
[off-list ref] wrote:
quoted hunk
This patch solves the coding style issues such as space after ,
and removes the blank lines

Signed-off-by: Mohammad Jamal <redacted>
---
 drivers/net/ieee802154/cc2520.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index f9df9fa..dd129be 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -513,7 +513,6 @@ err_tx:
        return rc;
 }

-
 static int cc2520_rx(struct cc2520_private *priv)
 {
        u8 len = 0, lqi = 0, bytes = 1;
@@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
        u8 rssi;
        int ret;

-       ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
+       ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
        if (ret)
                return ret;

        if (status != RSSI_VALID)
                return -EINVAL;

-       ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
+       ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
        if (ret)
                return ret;
@@ -947,7 +946,6 @@ static int cc2520_probe(struct spi_device *spi)
        if (ret)
                goto err_hw_init;

-
        gpio_set_value(pdata->vreg, HIGH);
        usleep_range(100, 150);

--
1.7.9.5
-- 
Thanks and Regards,
Varka Bhadram.

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

From: Sergei Shtylyov <hidden>
Date: 2015-01-23 12:37:52

Hello.

On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
This patch solves the coding style issues such as space after ,
    s/after/before/?
and removes the blank lines
   Extra blank lines, you mean?
Signed-off-by: Mohammad Jamal <redacted>
---
  drivers/net/ieee802154/cc2520.c |    6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
quoted hunk
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index f9df9fa..dd129be 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
[...]
quoted hunk
@@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
  	u8 rssi;
  	int ret;

-	ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
+	ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
  	if (ret)
  		return ret;

  	if (status != RSSI_VALID)
  		return -EINVAL;

-	ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
+	ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
[...]

WBR, Sergei

Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

From: Jamal Mohammad <hidden>
Date: 2015-01-23 12:44:59

On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov
[off-list ref] wrote:
Hello.

On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
quoted
This patch solves the coding style issues such as space after ,

   s/after/before/?
quoted
and removes the blank lines

  Extra blank lines, you mean?
quoted
Signed-off-by: Mohammad Jamal <redacted>
---
  drivers/net/ieee802154/cc2520.c |    6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
quoted
diff --git a/drivers/net/ieee802154/cc2520.c
b/drivers/net/ieee802154/cc2520.c
index f9df9fa..dd129be 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
[...]
quoted
@@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
        u8 rssi;
        int ret;

-       ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
+       ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
        if (ret)
                return ret;

        if (status != RSSI_VALID)
                return -EINVAL;

-       ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
+       ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
[...]

WBR, Sergei
Sorry for that,

i actually have cloned and linus torvalds git and when i ran
checkpatch.pl i have found some warnings. so this patch was removing
those warnings...as bhadram told that these warnings are already
removed in bluetooth-next tree...so this patch any how fails....
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help