[PATCH] net: wireless: b43legacy: radio.c: Remove unused function

Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <redacted>
---
 drivers/net/wireless/b43legacy/radio.c |   19 -------------------
 drivers/net/wireless/b43legacy/radio.h |    1 -
 2 files changed, 20 deletions(-)

diff --git a/drivers/net/wireless/b43legacy/radio.c b/drivers/net/wireless/b43legacy/radio.c
index 8961776..9501420 100644
--- a/drivers/net/wireless/b43legacy/radio.c
+++ b/drivers/net/wireless/b43legacy/radio.c

@@ -1743,25 +1743,6 @@ u16 freq_r3A_value(u16 frequency)
 	return value;
 }
 
-void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev)
-{
-	static const u8 data_high[5] = { 0x00, 0x40, 0x80, 0x90, 0xD0 };
-	static const u8 data_low[5]  = { 0x00, 0x01, 0x05, 0x06, 0x0A };
-	u16 tmp = b43legacy_radio_read16(dev, 0x001E);
-	int i;
-	int j;
-
-	for (i = 0; i < 5; i++) {
-		for (j = 0; j < 5; j++) {
-			if (tmp == (data_high[i] | data_low[j])) {
-				b43legacy_phy_write(dev, 0x0069, (i - j) << 8 |
-						    0x00C0);
-				return;
-			}
-		}
-	}
-}
-
 int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev,
 				  u8 channel,
 				  int synthetic_pu_workaround)

diff --git a/drivers/net/wireless/b43legacy/radio.h b/drivers/net/wireless/b43legacy/radio.h
index bccb3d7..dd2976d 100644
--- a/drivers/net/wireless/b43legacy/radio.h
+++ b/drivers/net/wireless/b43legacy/radio.h

@@ -92,7 +92,6 @@ void b43legacy_nrssi_hw_write(struct b43legacy_wldev *dev, u16 offset, s16 val);
 void b43legacy_nrssi_hw_update(struct b43legacy_wldev *dev, u16 val);
 void b43legacy_nrssi_mem_update(struct b43legacy_wldev *dev);
 
-void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev);
 u16 b43legacy_radio_calibrationvalue(struct b43legacy_wldev *dev);
 
 #endif /* B43legacy_RADIO_H_ */

-- 
1.7.10.4

On 1 January 2015 at 16:46, Rickard Strandqvist
[off-list ref] wrote:

Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

It seems to be for A-PHY based hardware (with 0x2060 radio id) which
is not handled by b43legacy. Should be safe to drop this code (we
won't likely need it).

Ack

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On 2 January 2015 at 13:05, Rafał Miłecki [off-list ref] wrote:

On 1 January 2015 at 16:46, Rickard Strandqvist
[off-list ref] wrote:

quoted

Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

It seems to be for A-PHY based hardware (with 0x2060 radio id) which
is not handled by b43legacy. Should be safe to drop this code (we
won't likely need it).

Ack

For future, we prefix patches with just a driver name. So this could
be simply called
b43legacy: radio.c: Remove unused function

-- 
Rafał

On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki [off-list ref] wrote:

On 2 January 2015 at 13:05, Rafał Miłecki [off-list ref] wrote:

quoted

On 1 January 2015 at 16:46, Rickard Strandqvist
[off-list ref] wrote:

quoted

Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

It seems to be for A-PHY based hardware (with 0x2060 radio id) which
is not handled by b43legacy. Should be safe to drop this code (we
won't likely need it).

Ack

For future, we prefix patches with just a driver name. So this could
be simply called
b43legacy: radio.c: Remove unused function

Alternatively...

"b43legacy: Remove unused function in radio.c"

BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck
to get such stuff?

- Sedat -

[1] https://lkml.org/lkml/2015/1/2/51