# Re: \[PATCH 1/3\] ipv6: Select fragment id during UFO/GSO segmentation if not set.

- From: Eric Dumazet \<hidden\>
- Date: 2015-01-27 14:38:01 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/01/10976479
- Thread: https://ratatoskr.run/netdev/2015/01/10976287/t.md

```text
On Tue, 2015-01-27 at 09:26 -0500, Vlad Yasevich wrote:

> That's what I originally wanted to do, but had to move and grow txflags thus
> skb_shinfo ended up growing.  I wanted to avoid that, so stole an skb flag.
> 
> I considered treating fragid == 0 as unset, but a 0 fragid is perfectly valid
> from the protocol perspective and could actually be generated by the id generator
> functions.  This may cause us to call the id generation multiple times.

With 32bit ID, you certainly can replace fragid=0 by fragid=0x80000000
and nobody will notice.

I certainly vote for not adding an extra bit in skb or skb_shared_info,
considering we already consume 32bits for this thing.

fragid are best effort, otherwise they would have 128bits.
```
