# Re: \[PATCH 1/2\] rhashtable: Introduce rhashtable\_walk\_\*

- From: Herbert Xu \<herbert@gondor.apana.org.au\>
- Date: 2015-01-27 10:12:20 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/01/10976438
- Thread: https://ratatoskr.run/netdev/2015/01/10975759/t.md

```text
On Tue, Jan 27, 2015 at 10:09:18AM +0000, David Laight wrote:
>
> But if err is non-zero you don't hold the mutex.
> Presumably the calling code also errors out immediately,
> so the RCU lock isn't needed at all.

No the calling code expects the RCU lock to be held because it
will always call stop.  Look at how seq_file works.

Cheers,
-- 
Email: Herbert Xu [ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
```
