# Re: \[PATCH 1/2\] rhashtable: Introduce rhashtable\_walk\_\*

- From: Herbert Xu \<herbert@gondor.apana.org.au\>
- Date: 2015-01-26 22:23:35 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/01/10976330
- Thread: https://ratatoskr.run/netdev/2015/01/10975759/t.md

```text
On Mon, Jan 26, 2015 at 10:09:24AM +0000, David Laight wrote:
>
> That doesn't look right to me.
> Surely you shouldn't be calling rcu_read_lock() when the mutex
> request is interrupted.
> 
> So maybe:
> 	err = mutex_lock_interruptible(&ht->mutex);
> 	if (err)
> 		return err;
> 	rcu_read_lock();

No, we need to grab the RCU read lock while holding the mutex
in order to prevent future resizes from happening once we release
the mutex.

We don't want to hold the mutex which would stop other walks from
starting.

Cheers,
-- 
Email: Herbert Xu [ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
```
