# Re: \[PATCH 7/9\] rhashtable: Per bucket locks \& deferred expansion/shrinking

- From: Thomas Graf \<tgraf@suug.ch\>
- Date: 2015-01-16 21:36:09 
- List: netdev
- Page: https://ratatoskr.run/netdev/2015/01/10975491
- Thread: https://ratatoskr.run/netdev/2014/12/10972989/t.md

```text
On 01/16/15 at 07:35pm, Patrick McHardy wrote:
> On 16.01, Thomas Graf wrote:
> > Right,but that's a Netlink dump issue and not specific to rhashtable.
> 
> Well, rhashtable (or generally resizing) will make it a lot worse.
> Usually we at worst miss entries which were added during the dump,
> which is made up by the notifications.
> 
> With resizing we might miss anything, its completely undeterministic.
> 
> > Putting the sequence number check in place should be sufficient
> > for sets, right?
> 
> I don't see how. The problem is that the ordering of the hash changes
> and it will skip different entries than those that have already been
> dumped.

Since an resize can only be triggered through insert/remove you
simply bump a sequence number when you insert/remove and have
userspace restart the dump when NLM_F_DUMP_INTR is set.
```
