Re: [PATCH] 8139too in linux-3.18.0: some potential bugs
From: Jia-Ju Bai <hidden>
Date: 2014-12-20 13:53:56
I have written it in the e-mail. Does not it display?? Okay, I send it again:
diff --git a/drivers/net/ethernet/realtek/8139too.cb/drivers/net/ethernet/realtek/8139too.c index 007b38c..f277c5f 100644
--- a/drivers/net/ethernet/realtek/8139too.c
+++ b/drivers/net/ethernet/realtek/8139too.c@@ -782,11 +782,11 @@ static struct net_device *rtl8139_init_board(structpci_dev *pdev) rc = pci_enable_device (pdev); if (rc) goto err_out; + disable_dev_on_err = 1; rc = pci_request_regions (pdev, DRV_NAME); if (rc) goto err_out; - disable_dev_on_err = 1; pci_set_master (pdev);
@@ -1098,6 +1098,7 @@ static int rtl8139_init_one(struct pci_dev *pdev, return 0; err_out: + netif_napi_del (&tp->napi); __rtl8139_cleanup_dev (dev); pci_disable_device (pdev); return i;
@@ -1112,6 +1113,7 @@ static void rtl8139_remove_one(struct pci_dev *pdev) assert (dev != NULL); cancel_delayed_work_sync(&tp->thread); + netif_napi_del (&tp->napi); unregister_netdev (dev);