Potential bugs found in 3c59x
From: Jia-Ju Bai <hidden>
Date: 2014-12-15 01:42:09
Recently I test linux device drivers 3.17.2. The target file is drivers/net/ethernet/3com/3c59x.c, which is used to build 3c59x.ko. I hope you can help me check my findings: [1] The function vortex_up is called by vortex_open when initializing the ethernet card driver. But when vortex_up is failed, which means that it returns the error value, "out" segment is executed immediately to halt the process. However, the resources allocated by __netdev_alloc_skb in vortex_open are not released by dev_kfree_skb when vortex_up is failed. [2] As shown in [1], one reason that vortex_up is failed is that pci_enable_device is failed(return the error value) in vortex_up, and "err_out" segment is executed immediately to return. Could you help me check these findings? Thank you very much, and I'm looking forward to your reply.