Re: [PATCH net-next] test: bpf: expand DIV_KX to DIV_MOD_KX
From: Alexei Starovoitov <hidden>
Date: 2014-12-01 17:44:59
On Mon, Dec 1, 2014 at 2:12 AM, Denis Kirjanov [off-list ref] wrote:
Expand DIV_KX to use BPF_MOD operation in the DIV_KX bpf 'classic' test. CC: Alexei Starovoitov <redacted> Signed-off-by: Denis Kirjanov <redacted>
Increases test coverage. Makes sense. Thanks Acked-by: Alexei Starovoitov <redacted>
quoted hunk
--- lib/test_bpf.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 3f167d2..80d78c5 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c@@ -124,7 +124,7 @@ static struct bpf_test tests[] = { { { 0, 0xfffffffd } } }, { - "DIV_KX", + "DIV_MOD_KX", .u.insns = { BPF_STMT(BPF_LD | BPF_IMM, 8), BPF_STMT(BPF_ALU | BPF_DIV | BPF_K, 2),@@ -134,12 +134,18 @@ static struct bpf_test tests[] = { BPF_STMT(BPF_MISC | BPF_TAX, 0), BPF_STMT(BPF_LD | BPF_IMM, 0xffffffff), BPF_STMT(BPF_ALU | BPF_DIV | BPF_K, 0x70000000), + BPF_STMT(BPF_MISC | BPF_TAX, 0), + BPF_STMT(BPF_LD | BPF_IMM, 0xffffffff), + BPF_STMT(BPF_ALU | BPF_MOD | BPF_X, 0), + BPF_STMT(BPF_MISC | BPF_TAX, 0), + BPF_STMT(BPF_LD | BPF_IMM, 0xffffffff), + BPF_STMT(BPF_ALU | BPF_MOD | BPF_K, 0x70000000), BPF_STMT(BPF_ALU | BPF_ADD | BPF_X, 0), BPF_STMT(BPF_RET | BPF_A, 0) }, CLASSIC | FLAG_NO_DATA, { }, - { { 0, 0x40000001 } } + { { 0, 0x20000000 } } }, { "AND_OR_LSH_K", --1.7.10.4