[PATCH] x86: bpf_jit_comp: simplify trivial boolean return
From: Quentin Lambert <hidden>
Date: 2014-11-26 09:14:52
Also in:
lkml
Subsystem:
bpf jit for x86 64-bit, bpf [general] (safe dynamic programs and tools), the rest, x86 architecture (32-bit and 64-bit) · Maintainers:
Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman, Kumar Kartikeya Dwivedi, Linus Torvalds, Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen
Remove if then else statements preceding boolean return. Occurences were found using Coccinelle. The semantic patch used was: @@ expression expr; @@ - if ( expr ) - return true; - else - return false; + return expr; Signed-off-by: Quentin Lambert <redacted> --- arch/x86/net/bpf_jit_comp.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c
index 3f62734..1542f39 100644
--- a/arch/x86/net/bpf_jit_comp.c
+++ b/arch/x86/net/bpf_jit_comp.c@@ -135,11 +135,9 @@ static const int reg2hex[] = { */ static inline bool is_ereg(u32 reg) { - if (reg == BPF_REG_5 || reg == AUX_REG || - (reg >= BPF_REG_7 && reg <= BPF_REG_9)) - return true; - else - return false; + return (reg == BPF_REG_5 || + reg == AUX_REG || + (reg >= BPF_REG_7 && reg <= BPF_REG_9)); } /* add modifiers if 'reg' maps to x64 registers r8..r15 */