Possible memory leak in function (r8712_setrttbl_cmd) not freeing pointer (ph2c) on error path
From: Ahmed Tamrawi <hidden>
Date: 2014-11-25 14:24:58
From: Ahmed Tamrawi <hidden>
Date: 2014-11-25 14:24:58
Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=88881 Linux Version [3.17-rc1] Configuration: Default configuration for x86 In function (r8712_setrttbl_cmd) file (drivers/staging/rtl8712/rtl871x_cmd.c): Function (r8712_setrttbl_cmd) allocates the variable (ph2c) at line 732 and passes it as a parameter to function (r8712_enqueue_cmd) at line 743. Function (r8712_setrttbl_cmd) returns (_SUCCESS) result regardless of the result of the called function (r8712_enqueue_cmd) which may return (_FAIL) at line 176. This failure causing the allocated object not to be queued and hence not freed later. Thus, causing a possible memory leak not freeing the (ph2c) pointer upon (_FAIL) return of function (r8712_enqueue_cmd). Source code reference for function (r8712_setrttbl_cmd): http://lxr.free-electrons.com/source/drivers/staging/rtl8712/rtl871x_cmd.c#L725 Source code reference for function (r8712_enqueue_cmd): http://lxr.free-electrons.com/source/drivers/staging/rtl8712/rtl871x_cmd.c#L171 ~Ahmed