[PATCH 1/1] ipv4: remove set but unused variable sha

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4296d

2 messages, 2 authors, 2014-10-27 · open the first message on its own page

[PATCH 1/1] ipv4: remove set but unused variable sha

From: Fabian Frederick <hidden>
Date: 2014-10-27 18:03:31

unsigned char *sha (source) was already in original git version
 but was never used.

Signed-off-by: Fabian Frederick <redacted>
---
 net/ipv4/ipconfig.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 648fa14..a896da5 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -498,7 +498,7 @@ ic_rarp_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
 	struct arphdr *rarp;
 	unsigned char *rarp_ptr;
 	__be32 sip, tip;
-	unsigned char *sha, *tha;		/* s for "source", t for "target" */
+	unsigned char *tha;		/* t for "target" */
 	struct ic_device *d;
 
 	if (!net_eq(dev_net(dev), &init_net))
@@ -549,7 +549,6 @@ ic_rarp_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
 		goto drop_unlock;	/* should never happen */
 
 	/* Extract variable-width fields */
-	sha = rarp_ptr;
 	rarp_ptr += dev->addr_len;
 	memcpy(&sip, rarp_ptr, 4);
 	rarp_ptr += 4;
-- 
1.9.1

Re: [PATCH 1/1] ipv4: remove set but unused variable sha

From: David Miller <davem@davemloft.net>
Date: 2014-10-27 20:04:26

From: Fabian Frederick <redacted>
Date: Mon, 27 Oct 2014 19:03:22 +0100
unsigned char *sha (source) was already in original git version
 but was never used.

Signed-off-by: Fabian Frederick <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help