[PATCH] drivers: net: ethernet: octeon_mgmt: fix a compiler warning

Subsystems: networking drivers, the rest

STALE4388d

3 messages, 3 authors, 2014-09-08 · open the first message on its own page

[PATCH] drivers: net: ethernet: octeon_mgmt: fix a compiler warning

From: Aaro Koskinen <hidden>
Date: 2014-09-08 15:03:41

Fix the following compiler warning:

drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_clean_tx_buffers':
drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
    ^

Signed-off-by: Aaro Koskinen <redacted>
---
 drivers/net/ethernet/octeon/octeon_mgmt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
index 979c698..a422930 100644
--- a/drivers/net/ethernet/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
@@ -290,9 +290,11 @@ static void octeon_mgmt_clean_tx_buffers(struct octeon_mgmt *p)
 		/* Read the hardware TX timestamp if one was recorded */
 		if (unlikely(re.s.tstamp)) {
 			struct skb_shared_hwtstamps ts;
+			u64 ns;
+
 			memset(&ts, 0, sizeof(ts));
 			/* Read the timestamp */
-			u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
+			ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
 			/* Remove the timestamp from the FIFO */
 			cvmx_write_csr(CVMX_MIXX_TSCTL(p->port), 0);
 			/* Tell the kernel about the timestamp */
-- 
2.1.0

Re: [PATCH] drivers: net: ethernet: octeon_mgmt: fix a compiler warning

From: David Daney <hidden>
Date: 2014-09-08 16:36:31

On 09/08/2014 08:01 AM, Aaro Koskinen wrote:
Fix the following compiler warning:

drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_clean_tx_buffers':
drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
     ^

Signed-off-by: Aaro Koskinen <redacted>
For some reason we missed this when the initial patch was created. 
Thanks for fixing it...

Acked-by: David Daney <redacted>

quoted hunk
---
  drivers/net/ethernet/octeon/octeon_mgmt.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c
index 979c698..a422930 100644
--- a/drivers/net/ethernet/octeon/octeon_mgmt.c
+++ b/drivers/net/ethernet/octeon/octeon_mgmt.c
@@ -290,9 +290,11 @@ static void octeon_mgmt_clean_tx_buffers(struct octeon_mgmt *p)
  		/* Read the hardware TX timestamp if one was recorded */
  		if (unlikely(re.s.tstamp)) {
  			struct skb_shared_hwtstamps ts;
+			u64 ns;
+
  			memset(&ts, 0, sizeof(ts));
  			/* Read the timestamp */
-			u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
+			ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
  			/* Remove the timestamp from the FIFO */
  			cvmx_write_csr(CVMX_MIXX_TSCTL(p->port), 0);
  			/* Tell the kernel about the timestamp */

Re: [PATCH] drivers: net: ethernet: octeon_mgmt: fix a compiler warning

From: David Miller <davem@davemloft.net>
Date: 2014-09-08 21:24:02

From: Aaro Koskinen <redacted>
Date: Mon,  8 Sep 2014 18:01:53 +0300
Fix the following compiler warning:

drivers/net/ethernet/octeon/octeon_mgmt.c: In function 'octeon_mgmt_clean_tx_buffers':
drivers/net/ethernet/octeon/octeon_mgmt.c:295:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    u64 ns = cvmx_read_csr(CVMX_MIXX_TSTAMP(p->port));
    ^

Signed-off-by: Aaro Koskinen <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help