: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
Sent: Wednesday, August 20, 2014 8:01 PM
To: Hayes Wang; netdev@vger.kernel.org
Cc: nic_swsd; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] r8152: remove clear_bp function
[...]
quoted
r8152b_disable_aldps(tp);
- rtl_clear_bp(tp);
Why leave 2 empty lines? One is enough.
The next patch would use another fucntion at the
same location. I skip removing the empty line and
re-adding it again. Is that better to do so? I would
resend the patches if the answer is yes.
Best Regards,
Hayes
On 08/21/2014 06:12 AM, Hayes Wang wrote:
[...]
quoted
quoted
r8152b_disable_aldps(tp);
- rtl_clear_bp(tp);
quoted
Why leave 2 empty lines? One is enough.
The next patch would use another fucntion at the
same location. I skip removing the empty line and
re-adding it again. Is that better to do so? I would
resend the patches if the answer is yes.
Sorry, I haven't looked at your next patch, too big for me. :-)
Best Regards,
Hayes
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
[...]
quoted
quoted
Why leave 2 empty lines? One is enough.
quoted
The next patch would use another fucntion at the
same location. I skip removing the empty line and
re-adding it again. Is that better to do so? I would
resend the patches if the answer is yes.
Sorry, I haven't looked at your next patch, too big for me. :-)
It's my mistake. I would avoid it next time. Thanks for your notice.
Best Regards,
Hayes