[PATCH] net/ipv4/igmp.c: Replace rcu_dereference() with rcu_access_pointer()

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4376d

2 messages, 2 authors, 2014-08-22 · open the first message on its own page

[PATCH] net/ipv4/igmp.c: Replace rcu_dereference() with rcu_access_pointer()

From: Andreea-Cristina Bernat <hidden>
Date: 2014-08-17 12:49:52

The "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes the replacement.

The following Coccinelle semantic patch was used:
@@
@@

(
 if(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
  ...+>)) {...}
|
 while(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
  ...+>)) {...}
)

Signed-off-by: Andreea-Cristina Bernat <redacted>
---
 net/ipv4/igmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
index 6748d42..94a96ad 100644
--- a/net/ipv4/igmp.c
+++ b/net/ipv4/igmp.c
@@ -2537,7 +2537,7 @@ static int igmp_mc_seq_show(struct seq_file *seq, void *v)
 		querier = "NONE";
 #endif
 
-		if (rcu_dereference(state->in_dev->mc_list) == im) {
+		if (rcu_access_pointer(state->in_dev->mc_list) == im) {
 			seq_printf(seq, "%d\t%-10s: %5d %7s\n",
 				   state->dev->ifindex, state->dev->name, state->in_dev->mc_count, querier);
 		}
-- 
1.9.1

Re: [PATCH] net/ipv4/igmp.c: Replace rcu_dereference() with rcu_access_pointer()

From: David Miller <davem@davemloft.net>
Date: 2014-08-22 19:28:14

From: Andreea-Cristina Bernat <redacted>
Date: Sun, 17 Aug 2014 15:49:41 +0300
The "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes the replacement.
 ...
Signed-off-by: Andreea-Cristina Bernat <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help