[PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer()

Subsystems: bonding driver, networking drivers, the rest

STALE4372d

2 messages, 2 authors, 2014-08-22 · open the first message on its own page

[PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer()

From: Andreea-Cristina Bernat <hidden>
Date: 2014-08-17 10:21:55

This "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes this replacement.

The following Coccinelle semantic patch was used for solving it:
@@
@@

(
 if(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
 ...+>)) {...}
|
 while(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
  ...+>)) {...}
)

Signed-off-by: Andreea-Cristina Bernat <redacted>
---
Changes in v2:
 - Modified subject line from
 "rcu: Replace rcu_dereference() with rcu_access_pointer()"
 to
 "bonding: Replace rcu_dereference() with rcu_access_pointer()",
 noted by David Miller [off-list ref]

 drivers/net/bonding/bond_alb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 76c0dad..1319c5b 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -1385,7 +1385,7 @@ static int bond_do_alb_xmit(struct sk_buff *skb, struct bonding *bond,
 	}
 
 	if (tx_slave && bond_slave_can_tx(tx_slave)) {
-		if (tx_slave != rcu_dereference(bond->curr_active_slave)) {
+		if (tx_slave != rcu_access_pointer(bond->curr_active_slave)) {
 			ether_addr_copy(eth_data->h_source,
 					tx_slave->dev->dev_addr);
 		}
-- 
1.9.1

Re: [PATCH v2] bonding: Replace rcu_dereference() with rcu_access_pointer()

From: David Miller <davem@davemloft.net>
Date: 2014-08-22 19:28:05

From: Andreea-Cristina Bernat <redacted>
Date: Sun, 17 Aug 2014 13:21:45 +0300
This "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes this replacement.
 ...
Signed-off-by: Andreea-Cristina Bernat <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help