[PATCH] smsc: replace WARN_ON() with WARN_ON_SMP()

spin_is_locked() always return false in uniprocessor configuration and therefore it
would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <redacted>
---
 drivers/net/ethernet/smsc/smsc911x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.h b/drivers/net/ethernet/smsc/smsc911x.h
index 2395395..54d6489 100644
--- a/drivers/net/ethernet/smsc/smsc911x.h
+++ b/drivers/net/ethernet/smsc/smsc911x.h

@@ -51,7 +51,7 @@
 
 #ifdef CONFIG_DEBUG_SPINLOCK
 #define SMSC_ASSERT_MAC_LOCK(pdata) \
-		WARN_ON(!spin_is_locked(&pdata->mac_lock))
+		WARN_ON_SMP(!spin_is_locked(&pdata->mac_lock))
 #else
 #define SMSC_ASSERT_MAC_LOCK(pdata) do {} while (0)
 #endif				/* CONFIG_DEBUG_SPINLOCK */

-- 
1.7.11.7

On Mon, Aug 11, 2014 at 01:46:23PM +0530, Sanjeev Sharma wrote:

spin_is_locked() always return false in uniprocessor configuration and therefore it
would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <redacted>
---
 drivers/net/ethernet/smsc/smsc911x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hint, I have nothing to do with this file, no need to send a patch for
it to me, I can't do anything with it...

thanks,

greg k-h

Ok Greg probably Steve will have a look.

Regards
Sanjeev Sharma

-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org] 
Sent: Monday, August 11, 2014 1:50 PM
To: Sharma, Sanjeev
Cc: steve.glendinning@shawell.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smsc: replace WARN_ON() with WARN_ON_SMP()

On Mon, Aug 11, 2014 at 01:46:23PM +0530, Sanjeev Sharma wrote:

spin_is_locked() always return false in uniprocessor configuration and 
therefore it would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <redacted>
---
 drivers/net/ethernet/smsc/smsc911x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hint, I have nothing to do with this file, no need to send a patch for it to me, I can't do anything with it...

thanks,

greg k-h

From: Sanjeev Sharma <redacted>
Date: Mon, 11 Aug 2014 13:46:23 +0530

spin_is_locked() always return false in uniprocessor configuration and therefore it
would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <redacted>

This looks fine, applied, thanks.

Thanks !

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net] 
Sent: Tuesday, August 12, 2014 3:09 AM
To: Sharma, Sanjeev
Cc: gregkh@linuxfoundation.org; steve.glendinning@shawell.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smsc: replace WARN_ON() with WARN_ON_SMP()

From: Sanjeev Sharma <redacted>
Date: Mon, 11 Aug 2014 13:46:23 +0530

spin_is_locked() always return false in uniprocessor configuration and 
therefore it would be advise to repalce with WARN_ON_SMP().

Signed-off-by: Sanjeev Sharma <redacted>

This looks fine, applied, thanks.