[PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put

Subsystems: networking drivers, the rest

STALE4387d

2 messages, 2 authors, 2014-08-08 · open the first message on its own page

[PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put

From: Julia Lawall <hidden>
Date: 2014-08-08 10:11:28

From: Julia Lawall <redacted>

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/net/ethernet/freescale/fec_mpc52xx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/ethernet/freescale/fec_mpc52xx.c
index 9947765..ff55fbb 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx.c
@@ -1015,8 +1015,7 @@ mpc52xx_fec_remove(struct platform_device *op)
 
 	unregister_netdev(ndev);
 
-	if (priv->phy_node)
-		of_node_put(priv->phy_node);
+	of_node_put(priv->phy_node);
 	priv->phy_node = NULL;
 
 	irq_dispose_mapping(ndev->irq);

Re: [PATCH 13/14] fec_mpc52xx: delete unneeded test before of_node_put

From: David Miller <davem@davemloft.net>
Date: 2014-08-08 17:28:53

From: Julia Lawall <redacted>
Date: Fri,  8 Aug 2014 12:07:54 +0200
From: Julia Lawall <redacted>

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
 ...
Signed-off-by: Julia Lawall <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help