# \[PATCH 8/25\] dscc4: Replace DEFINE\_PCI\_DEVICE\_TABLE macro use

- From: Benoit Taine \<hidden\>
- Date: 2014-07-18 15:38:27 
- List: netdev
- Page: https://ratatoskr.run/netdev/2014/07/4298767
- Thread: https://ratatoskr.run/netdev/2014/07/4298753/t.md

```text
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
kernel coding style guidelines. This issue was reported by checkpatch.

Signed-off-by: Benoit Taine <redacted>

---
Tested by compilation without errors.

 drivers/net/wan/dscc4.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 288610d..0822356 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -2039,7 +2039,7 @@ static int __init dscc4_setup(char *str)
 __setup("dscc4.setup=", dscc4_setup);
 #endif
 
-static DEFINE_PCI_DEVICE_TABLE(dscc4_pci_tbl) = {
+static const struct pci_device_id dscc4_pci_tbl[] = {
 	{ PCI_VENDOR_ID_SIEMENS, PCI_DEVICE_ID_SIEMENS_DSCC4,
 	        PCI_ANY_ID, PCI_ANY_ID, },
 	{ 0,}
```