[PATCH] atm: Remove fix me in solos-pci

Subsystems: atm, the rest

STALE4403d

3 messages, 2 authors, 2014-07-22 · open the first message on its own page

[PATCH] atm: Remove fix me in solos-pci

From: Nicholas Krause <hidden>
Date: 2014-07-22 04:07:26

This removes a fix me as the default statement for solos_bh is correct
and needs no fixing.

Signed-off-by: Nicholas Krause <redacted>
---
 drivers/atm/solos-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 943cf0d..58a0a8f 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
 				break;
 
 			case PKT_COMMAND:
-			default: /* FIXME: Not really, surely? */
+			default:
 				if (process_command(card, port, skb))
 					break;
 				spin_lock(&card->cli_queue_lock);
-- 
1.9.1

Re: [PATCH] atm: Remove fix me in solos-pci

From: chas williams - CONTRACTOR <hidden>
Date: 2014-07-22 11:43:53

Guy Ellis of Transverse says that Nathan Williams,
nathan@traverse.com.au, will address this issue when he returns
from vacation.  So let's just wait for the 'official' fix.

On Tue, 22 Jul 2014 00:07:20 -0400
Nicholas Krause [off-list ref] wrote:
quoted hunk
This removes a fix me as the default statement for solos_bh is correct
and needs no fixing.

Signed-off-by: Nicholas Krause <redacted>
---
 drivers/atm/solos-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 943cf0d..58a0a8f 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
 				break;
 
 			case PKT_COMMAND:
-			default: /* FIXME: Not really, surely? */
+			default:
 				if (process_command(card, port, skb))
 					break;
 				spin_lock(&card->cli_queue_lock);

Re: [PATCH] atm: Remove fix me in solos-pci

From: Nick Krause <hidden>
Date: 2014-07-22 17:47:38

On Tue, Jul 22, 2014 at 7:43 AM, chas williams - CONTRACTOR
[off-list ref] wrote:
Guy Ellis of Transverse says that Nathan Williams,
nathan@traverse.com.au, will address this issue when he returns
from vacation.  So let's just wait for the 'official' fix.

On Tue, 22 Jul 2014 00:07:20 -0400
Nicholas Krause [off-list ref] wrote:
quoted
This removes a fix me as the default statement for solos_bh is correct
and needs no fixing.

Signed-off-by: Nicholas Krause <redacted>
---
 drivers/atm/solos-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 943cf0d..58a0a8f 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -851,7 +851,7 @@ static void solos_bh(unsigned long card_arg)
                              break;

                      case PKT_COMMAND:
-                     default: /* FIXME: Not really, surely? */
+                     default:
                              if (process_command(card, port, skb))
                                      break;
                              spin_lock(&card->cli_queue_lock);
Very well then I just this is closed.
Cheers Nick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help