[PATCH net-next v4 11/11] openvswitch: Add skb_clone NULL check for the sampling action.
From: Pravin B Shelar <hidden>
Date: 2014-07-17 00:19:44
Subsystem:
networking [general], openvswitch, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Aaron Conole, Eelco Chaudron, Ilya Maximets, Linus Torvalds
From: Andy Zhou <redacted> Fix a bug where skb_clone() NULL check is missing in sample action implementation. Signed-off-by: Andy Zhou <redacted> Signed-off-by: Pravin B Shelar <redacted> --- net/openvswitch/actions.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 5920512..09ccbb8 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c@@ -477,6 +477,8 @@ static int sample(struct datapath *dp, struct sk_buff *skb, skb_get(skb); } else { sample_skb = skb_clone(skb, GFP_ATOMIC); + if (!sample_skb) /* Skip sample action when out of memory. */ + return 0; } /* Note that do_execute_actions() never consumes skb.
--
1.9.3