[PATCH] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

Subsystems: open firmware and flattened device tree, the rest

STALE4458d

6 messages, 3 authors, 2014-06-23 · open the first message on its own page

[PATCH] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: Richard Retanubun <hidden>
Date: 2014-06-19 17:35:34

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun <redacted>
---
 drivers/of/of_mdio.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 7700ddc..c389e7b 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c

@@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
 	fixed_link_node = of_get_child_by_name(np, "fixed-link");
 	if (fixed_link_node) {
 		status.link = 1;
-		status.duplex = of_property_read_bool(np, "full-duplex");
+		status.duplex = of_property_read_bool(fixed_link_node,
+					"full-duplex");
 		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
 			return -EINVAL;
-		status.pause = of_property_read_bool(np, "pause");
-		status.asym_pause = of_property_read_bool(np, "asym-pause");
+		status.pause = of_property_read_bool(fixed_link_node, "pause");
+		status.asym_pause = of_property_read_bool(fixed_link_node,
+						"asym-pause");
 		of_node_put(fixed_link_node);
 		return fixed_phy_register(PHY_POLL, &status, np);
 	}

-- 
1.8.5.1

Re: [PATCH] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: Sergei Shtylyov <hidden>
Date: 2014-06-19 19:32:32

Hello.

On 06/19/2014 09:35 PM, Richard Retanubun wrote:

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun <redacted>
---
  drivers/of/of_mdio.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

quoted hunk

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 7700ddc..c389e7b 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c

@@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
  	fixed_link_node = of_get_child_by_name(np, "fixed-link");
  	if (fixed_link_node) {
  		status.link = 1;
-		status.duplex = of_property_read_bool(np, "full-duplex");
+		status.duplex = of_property_read_bool(fixed_link_node,
+					"full-duplex");

    The continuation line should start under 'fixed_link_node', according to 
the networking coding style.

  		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
  			return -EINVAL;
-		status.pause = of_property_read_bool(np, "pause");
-		status.asym_pause = of_property_read_bool(np, "asym-pause");
+		status.pause = of_property_read_bool(fixed_link_node, "pause");
+		status.asym_pause = of_property_read_bool(fixed_link_node,
+						"asym-pause");

    Same here...

WBR, Sergei

[PATCH v2] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: Richard Retanubun <hidden>
Date: 2014-06-19 21:28:57

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun <redacted>
---
v2: Clean up code indentation. Thanks Sergei!

 drivers/of/of_mdio.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 7700ddc..b5f7817 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c

@@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
 	fixed_link_node = of_get_child_by_name(np, "fixed-link");
 	if (fixed_link_node) {
 		status.link = 1;
-		status.duplex = of_property_read_bool(np, "full-duplex");
+		status.duplex = of_property_read_bool(fixed_link_node,
+							"full-duplex");
 		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
 			return -EINVAL;
-		status.pause = of_property_read_bool(np, "pause");
-		status.asym_pause = of_property_read_bool(np, "asym-pause");
+		status.pause = of_property_read_bool(fixed_link_node, "pause");
+		status.asym_pause = of_property_read_bool(fixed_link_node,
+								"asym-pause");
 		of_node_put(fixed_link_node);
 		return fixed_phy_register(PHY_POLL, &status, np);
 	}

-- 
1.8.5.1

Re: [PATCH v2] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: Sergei Shtylyov <hidden>
Date: 2014-06-19 21:34:27

Hello.

On 06/20/2014 01:28 AM, Richard Retanubun wrote:

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun <redacted>
---
v2: Clean up code indentation. Thanks Sergei!

    Unfortunately, you've misunderstood me. :-/

  drivers/of/of_mdio.c | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

quoted hunk

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 7700ddc..b5f7817 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c

@@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
  	fixed_link_node = of_get_child_by_name(np, "fixed-link");
  	if (fixed_link_node) {
  		status.link = 1;
-		status.duplex = of_property_read_bool(np, "full-duplex");
+		status.duplex = of_property_read_bool(fixed_link_node,
+							"full-duplex");

    When I said that continuation line should start under 'fixed_link_node', I 
meant it should start right under first letter of this name, after (. You 
don't need to use tabs only when indenting the networking code, appropriate 
number of spaces after tabs is OK.

WBR, Sergei

[PATCH v3] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: Richard Retanubun <hidden>
Date: 2014-06-20 14:11:07

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun <redacted>
---
v3: New and improved code indent.

 drivers/of/of_mdio.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 7700ddc..3812596 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c

@@ -290,11 +290,13 @@ int of_phy_register_fixed_link(struct device_node *np)
 	fixed_link_node = of_get_child_by_name(np, "fixed-link");
 	if (fixed_link_node) {
 		status.link = 1;
-		status.duplex = of_property_read_bool(np, "full-duplex");
+		status.duplex = of_property_read_bool(fixed_link_node,
+						      "full-duplex");
 		if (of_property_read_u32(fixed_link_node, "speed", &status.speed))
 			return -EINVAL;
-		status.pause = of_property_read_bool(np, "pause");
-		status.asym_pause = of_property_read_bool(np, "asym-pause");
+		status.pause = of_property_read_bool(fixed_link_node, "pause");
+		status.asym_pause = of_property_read_bool(fixed_link_node,
+							  "asym-pause");
 		of_node_put(fixed_link_node);
 		return fixed_phy_register(PHY_POLL, &status, np);
 	}

-- 
1.8.5.1

Re: [PATCH v3] of: mdio: fixup of_phy_register_fixed_link parsing of new bindings

From: David Miller <davem@davemloft.net>
Date: 2014-06-23 04:35:43

From: Richard Retanubun <redacted>
Date: Fri, 20 Jun 2014 10:11:07 -0400

Fixes commit 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")

Fix the parsing of the new fixed link dts bindings for duplex,
pause, and asym_pause by using the correct device node pointer.

Signed-off-by: Richard Retanubun <redacted>

Applied, thank you.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help