[PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE4419d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2014-08-05 · open the first message on its own page

[PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up

From: chenweilong <hidden>
Date: 2014-06-17 10:23:59

Hi Greg,

Please queue this for 3.4 stable kernel.

It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951

The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either. So I had to write this one.

====================

From: Gao feng <redacted>

commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.

This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.It's very worthy to be
applied to stable 3.4 kernels.

The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951


CC: Sabrina Dubroca <sd@queasysnail.net>
CC: Hannes Frederic Sowa <redacted>
Reported-by: Weilong Chen <redacted>
Signed-off-by: Weilong Chen <redacted>
Signed-off-by: Gao feng <redacted>
Acked-by: Hannes Frederic Sowa <redacted>
Signed-off-by: David S. Miller <davem@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <redacted>
Signed-off-by: Li Zefan <redacted>
---
 net/ipv6/addrconf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
 			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
 				continue;

-			if (sp_ifa->rt)
-				continue;
+			if (sp_ifa->rt) {
+				/* This dst has been added to garbage list when
+				 * lo device down, release this obsolete dst and
+				 * reallocate a new router for ifa.
+				 */
+				if (sp_ifa->rt->dst.obsolete > 0) {
+					dst_release(sp_ifa->rt);
+					sp_ifa->rt = NULL;
+				} else {
+					continue;
+				}
+			}

 			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);

-- 1.7.12

Re: [PATCH 3.4-stable] ipv6: reallocate addrconf router for ipv6 address when lo, device up

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2014-08-05 18:18:35

On Tue, Jun 17, 2014 at 06:23:59PM +0800, chenweilong wrote:
Hi Greg,

Please queue this for 3.4 stable kernel.

It fix the bug 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951

The patch can't be applied directly, as it' used the function introduced
by "commit 94e187c0" ip6_rt_put(), that patch can't be applied directly
either. So I had to write this one.
Now applied, can you also provide a version for 3.10-stable as I think
it is needd there also, right?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help