hyperv: fix apparent cut-n-paste error in send path teardown

Subsystems: hyper-v/azure core and drivers, networking drivers, the rest

3 messages, 3 authors, 2014-06-17 · open the first message on its own page

hyperv: fix apparent cut-n-paste error in send path teardown

From: Dave Jones <hidden>
Date: 2014-06-16 20:59:12

c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
some teardown code that looks like it was copied from the recieve path
above, but missed a variable name replacement.

Signed-off-by: Dave Jones <redacted>
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index c041f63a6d30..4ed38eaecea8 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device *net_device)
 				   "unable to teardown send buffer's gpadl\n");
 			return ret;
 		}
-		net_device->recv_buf_gpadl_handle = 0;
+		net_device->send_buf_gpadl_handle = 0;
 	}
 	if (net_device->send_buf) {
 		/* Free up the receive buffer */

Re: hyperv: fix apparent cut-n-paste error in send path teardown

From: David Miller <davem@davemloft.net>
Date: 2014-06-17 04:36:41

From: Dave Jones <redacted>
Date: Mon, 16 Jun 2014 16:59:02 -0400
c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
some teardown code that looks like it was copied from the recieve path
above, but missed a variable name replacement.

Signed-off-by: Dave Jones <redacted>
Good catch, applied, thanks Dave.

RE: hyperv: fix apparent cut-n-paste error in send path teardown

From: KY Srinivasan <kys@microsoft.com>
Date: 2014-06-17 10:29:02

-----Original Message-----
From: Dave Jones [mailto:davej@redhat.com]
Sent: Monday, June 16, 2014 1:59 PM
To: netdev@vger.kernel.org
Cc: KY Srinivasan
Subject: hyperv: fix apparent cut-n-paste error in send path teardown

c25aaf814a63: "hyperv: Enable sendbuf mechanism on the send path" added
some teardown code that looks like it was copied from the recieve path
above, but missed a variable name replacement.
Thank you.

K. Y
quoted hunk
Signed-off-by: Dave Jones <redacted>
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index
c041f63a6d30..4ed38eaecea8 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -189,7 +189,7 @@ static int netvsc_destroy_buf(struct netvsc_device
*net_device)
 				   "unable to teardown send buffer's
gpadl\n");
 			return ret;
 		}
-		net_device->recv_buf_gpadl_handle = 0;
+		net_device->send_buf_gpadl_handle = 0;
 	}
 	if (net_device->send_buf) {
 		/* Free up the receive buffer */
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help