[PATCH] net/fsl: Make xgmac_mdio read error message useful

Subsystems: networking drivers, the rest

STALE4498d

2 messages, 2 authors, 2014-06-11 · open the first message on its own page

[PATCH] net/fsl: Make xgmac_mdio read error message useful

From: Shruti Kanetkar <hidden>
Date: 2014-06-11 18:41:52

Print the device address, the register number and the PHY ID for
which the MDIO read operation failed

Signed-off-by: Shruti Kanetkar <redacted>
---
 drivers/net/ethernet/freescale/xgmac_mdio.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index d449fcb..0c9d55c 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -162,7 +162,9 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
 
 	/* Return all Fs if nothing was there */
 	if (in_be32(&regs->mdio_stat) & MDIO_STAT_RD_ER) {
-		dev_err(&bus->dev, "MDIO read error\n");
+		dev_err(&bus->dev,
+			"Error while reading PHY%d reg at %d.%d\n",
+			phy_id, dev_addr, regnum);
 		return 0xffff;
 	}
 
-- 
1.8.3.1

Re: [PATCH] net/fsl: Make xgmac_mdio read error message useful

From: David Miller <davem@davemloft.net>
Date: 2014-06-11 22:59:16

From: Shruti Kanetkar <redacted>
Date: Wed, 11 Jun 2014 13:41:40 -0500
Print the device address, the register number and the PHY ID for
which the MDIO read operation failed

Signed-off-by: Shruti Kanetkar <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help